Skip to content

Conversation

@priyaramani
Copy link
Contributor

@priyaramani priyaramani commented Apr 19, 2022

Stack from ghstack (oldest at bottom):

Move static dispatch logic into Operators.cpp instead of having them duplicated in Functions.h and TensorBody.h

Differential Revision: D35702065

…s.cpp

Move static dispatch logic into Operators.cpp instead of having them duplicated in Functions.h and TensorBody.h

Differential Revision: [D35702065](https://our.internmc.facebook.com/intern/diff/D35702065/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 19, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 6c35eba (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

…to Operators.cpp"

Move static dispatch logic into Operators.cpp instead of having them duplicated in Functions.h and TensorBody.h

Differential Revision: [D35702065](https://our.internmc.facebook.com/intern/diff/D35702065/)

[ghstack-poisoned]
…to Operators.cpp"

Move static dispatch logic into Operators.cpp instead of having them duplicated in Functions.h and TensorBody.h

Differential Revision: [D35702065](https://our.internmc.facebook.com/intern/diff/D35702065/)

[ghstack-poisoned]
…to Operators.cpp"

Move static dispatch logic into Operators.cpp instead of having them duplicated in Functions.h and TensorBody.h

Differential Revision: [D35702065](https://our.internmc.facebook.com/intern/diff/D35702065/)

[ghstack-poisoned]
…to Operators.cpp"

Move static dispatch logic into Operators.cpp instead of having them duplicated in Functions.h and TensorBody.h

Differential Revision: [D35702065](https://our.internmc.facebook.com/intern/diff/D35702065/)

[ghstack-poisoned]
…to Operators.cpp"

Move static dispatch logic into Operators.cpp instead of having them duplicated in Functions.h and TensorBody.h

Differential Revision: [D35702065](https://our.internmc.facebook.com/intern/diff/D35702065/)

[ghstack-poisoned]
priyaramani added a commit that referenced this pull request Apr 22, 2022
…s.cpp

Pull Request resolved: #76058

Move static dispatch logic into Operators.cpp instead of having them duplicated in Functions.h and TensorBody.h
ghstack-source-id: 154616593

Differential Revision: [D35702065](https://our.internmc.facebook.com/intern/diff/D35702065/)
facebook-github-bot pushed a commit that referenced this pull request Apr 23, 2022
…s.cpp (#76058)

Summary:
Pull Request resolved: #76058

Move static dispatch logic into Operators.cpp instead of having them duplicated in Functions.h and TensorBody.h
ghstack-source-id: 154616593

Test Plan:
Builds lite predictor with lightweight_dispatch enabled
```
buck build --config pt.enable_lightweight_dispatch=1 --config pt.static_dispatch_backend="CPU;QuantizedCPU;CompositeExplicitAutograd" //xplat/caffe2/fb/lite_predictor:lite_predictor_flatbuffer
```

Reviewed By: larryliu0820, bdhirsh

Differential Revision: D35702065

fbshipit-source-id: 263fe77936b63e41c4efea953be518e81a2c55c6
@github-actions
Copy link
Contributor

Hey @priyaramani.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/priyaramani/13/head branch April 26, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants