Skip to content

[lint] correctly display annotations for all severities #76348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[lint] correctly display annotations for all severities #76348

wants to merge 3 commits into from

Conversation

@suo
Copy link
Member

@suo suo commented Apr 25, 2022 •
edited
Loading

Stack from ghstack:

GitHub's problem matchers only match against "warning" or "error" as
severities. So translate the "advice" and "disabled" severities into
warnings so they'll show up.

@suo
[lint] correctly display annotations for all severities
cffe9e0 
GitHub's problem matchers only match against "warning" or "error" as
severities. So translate the "advice" and "disabled" severities into
warnings so they'll show up.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 25, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 58189e3 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@suo
Update on "[lint] correctly display annotations for all severities"
cdff4d1 
GitHub's problem matchers only match against "warning" or "error" as
severities. So translate the "advice" and "disabled" severities into
warnings so they'll show up.

[ghstack-poisoned]
@suo
Copy link
Member Author

suo commented Apr 25, 2022

image

@suo
Update on "[lint] correctly display annotations for all severities"
58189e3 
GitHub's problem matchers only match against "warning" or "error" as
severities. So translate the "advice" and "disabled" severities into
warnings so they'll show up.

[ghstack-poisoned]
suo added a commit that referenced this pull request Apr 25, 2022
@suo
[lint] correctly display annotations for all severities
6597241 
GitHub's problem matchers only match against "warning" or "error" as
severities. So translate the "advice" and "disabled" severities into
warnings so they'll show up.

ghstack-source-id: d6a0537
Pull Request resolved: #76348
@suo
Copy link
Member Author

suo commented Apr 25, 2022

@justinchuby this fixes the issue you were seeing with flake8

@justinchuby
Copy link
Collaborator

Just wondering: is it possible to un-escape the raw messages in the annotation?

@suo
Copy link
Member Author

suo commented Apr 25, 2022

Looks like yes: actions/toolkit#319 (comment)

@suo
Copy link
Member Author

suo commented Apr 25, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

Hey @suo.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2022
@suo @facebook-github-bot
[lint] correctly display annotations for all severities (#76348)
7b1cac4 
Summary:
GitHub's problem matchers only match against "warning" or "error" as
severities. So translate the "advice" and "disabled" severities into
warnings so they'll show up.

Pull Request resolved: #76348

Approved by: https://github.com/seemethere

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/1e1118957f63e98b6924f0e8ff20262dd347a965

Reviewed By: osalpekar

Differential Revision: D35938201

Pulled By: suo

fbshipit-source-id: 06565469cadfc5e371920337d4f9ea51b1bc27cc
@facebook-github-bot facebook-github-bot deleted the gh/suo/512/head branch April 29, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@janeyx99 janeyx99 Awaiting requested review from janeyx99

@atalman atalman Awaiting requested review from atalman

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suo @facebook-github-bot @justinchuby @seemethere