Skip to content

LT tutorial [WIP] #76392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

LT tutorial [WIP] #76392

wants to merge 4 commits into from

Conversation

Krovatkin
Copy link
Contributor

Fixes #ISSUE_NUMBER

@Krovatkin Krovatkin requested a review from wconstab April 26, 2022 18:26
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 26, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 258e0aa (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

wconstab
wconstab reviewed Apr 26, 2022
View reviewed changes
torch/csrc/lazy/tutorial.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can run

wconstab
wconstab reviewed Apr 26, 2022
View reviewed changes
torch/csrc/lazy/tutorial.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol. really? maybe we don't need that here, i think it digresses the main point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no spiel 😢

wconstab
wconstab reviewed Apr 26, 2022
View reviewed changes
torch/csrc/lazy/tutorial.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if your

a non-trivial

wconstab
wconstab reviewed Apr 26, 2022
View reviewed changes
torch/csrc/lazy/tutorial.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuda_kwargs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, last night I made sure the model runs and trains, I'll push the fixes shortly

wconstab
wconstab approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@wconstab wconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! thanks so much @Krovatkin

@Krovatkin Krovatkin force-pushed the krovatkin/lt_tutorial branch from 119daf5 to 221454c Compare April 27, 2022 23:47
@Krovatkin Krovatkin force-pushed the krovatkin/lt_tutorial branch from dac246f to 258e0aa Compare May 9, 2022 07:31
@Krovatkin
Copy link
Contributor Author

@pytorchbot merge this

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

Hey @Krovatkin.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@suo
Copy link
Member

suo commented May 9, 2022

@Krovatkin hey in the future, do you mind editing the commit message with something more descriptive when landing? It helps people who are monitoring master understand the changes. Thanks :)

@malfet
Copy link
Contributor

malfet commented May 9, 2022

@Krovatkin why did you merge an issue with Work-in-progress in title? Als, please remove "Fixes #ISSUE_NUMER" if there are no issue associated with PR

facebook-github-bot pushed a commit that referenced this pull request May 13, 2022
@Krovatkin @facebook-github-bot
LT tutorial [WIP] (#76392) (#76392)
ce59b9c 
Summary:
Fixes #ISSUE_NUMBER

Pull Request resolved: #76392
Approved by: https://github.com/wconstab

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/a6341d2ce539cafae225705156a5534eaa54bb32

Reviewed By: malfet, mikekgfb

Differential Revision: D36269306

Pulled By: Krovatkin

fbshipit-source-id: c3d2553a433cd4216171c87ff23839f0bace0e98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wconstab wconstab wconstab approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Krovatkin @facebook-github-bot @suo @malfet @wconstab @pytorchmergebot