ns for fx: more meaningful error message when creating shadow model #76468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This makes the error message when copying an unsupported node more verbose. This is useful to debug where specifically in a user model this is failing. Test plan: 1. hardcode this condition to hit 2. run NS tests 3. verify the exception now prints details about the offending node [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Apr 27, 2022
Summary: This makes the error message when copying an unsupported node more verbose. This is useful to debug where specifically in a user model this is failing. Test plan: 1. hardcode this condition to hit 2. run NS tests 3. verify the exception now prints details about the offending node ghstack-source-id: a0caf5d Pull Request resolved: #76468
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 9709054 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
approved these changes
Apr 27, 2022
…dow model" Summary: This makes the error message when copying an unsupported node more verbose. This is useful to debug where specifically in a user model this is failing. Test plan: 1. hardcode this condition to hit 2. run NS tests 3. verify the exception now prints details about the offending node Differential Revision: [D35978652](https://our.internmc.facebook.com/intern/diff/D35978652) [ghstack-poisoned]
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…dow model" Summary: This makes the error message when copying an unsupported node more verbose. This is useful to debug where specifically in a user model this is failing. Test plan: 1. hardcode this condition to hit 2. run NS tests 3. verify the exception now prints details about the offending node Differential Revision: [D35978652](https://our.internmc.facebook.com/intern/diff/D35978652) [ghstack-poisoned]
|
@vkuzo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 3, 2022
…76468) Summary: Pull Request resolved: #76468 This makes the error message when copying an unsupported node more verbose. This is useful to debug where specifically in a user model this is failing. Test Plan: 1. hardcode this condition to hit 2. run NS tests 3. verify the exception now prints details about the offending node Reviewed By: jerryzh168 Differential Revision: D35978652 Pulled By: vkuzo fbshipit-source-id: 9cc93dfa46469bf6ef60aa38d4011041b6709df9
vkuzo
added
release notes: quantization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This makes the error message when copying an unsupported node more verbose.
This is useful to debug where specifically in a user model this is failing.
Test plan:
Differential Revision: D35978652