[GHF] Small cleanup #77004
Closed
[GHF] Small cleanup #77004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use double quotes for Python string literals (per https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#strings ) - Do not post comment of merge_on_green called with dry_run argument - Dismantle pyramid of doom (and avoid infinite while) by specifying timeout as exit criteria - Use `handle_exception` for revert workflow as well [ghstack-poisoned]
🔗 Helpful links
❌ 6 New FailuresAs of commit 4e4b181 (more details on the Dr. CI page): Expand to see more
🕵️ 6 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This was referenced May 6, 2022
- Use double quotes for Python string literals (per https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#strings ) - Do not post comment of merge_on_green called with dry_run argument - Dismantle pyramid of doom (and avoid infinite while) by specifying timeout as exit criteria - Use `handle_exception` for revert workflow as well [ghstack-poisoned]
mehtanirav
approved these changes
May 6, 2022
| last_exception = '' | ||
| while True: | ||
| elapsed_time = 0.0 | ||
| while elapsed_time < 400 * 60: |
There was a problem hiding this comment.
curious why we have such long (6+ hours) timeout. Does merging PR also run additional CI jobs?
There was a problem hiding this comment.
No idea, 6h limits sounds wrong to me (and the job would probably be killed earlier)
@zengk95 care to explain?
There was a problem hiding this comment.
I was thinking the scenario where
Person creates PR > Triggers CI > Immediately after, they write merge this > CI can potentially take 4-5 hours to run so this script spins for around 6 hours (once we make those tests mandatory)? which only gives us a 1 or 2 hour overhead. I chose 6 hours cause I think that's the default GHA timeout.
Or the scenario where they retrigger CI by pushing another commit after like an hour or so and still want to land it when green.
- Use double quotes for Python string literals (per https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#strings ) - Do not post comment of merge_on_green called with dry_run argument - Dismantle pyramid of doom (and avoid infinite while) by specifying timeout as exit criteria - Use `handle_exception` for revert workflow as well [ghstack-poisoned]
|
@pytorchbot merge on green this |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 13, 2022
Summary: - Use double quotes for Python string literals (per https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#strings ) - Do not add label if merge_on_green is called with dry_run argument - Dismantle pyramid of doom (and avoid infinite while) by specifying timeout as exit criteria - Use `handle_exception` for revert workflow as well - Do not double post comment if merge_on_green times out Pull Request resolved: #77004 Approved by: https://github.com/mehtanirav Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/9f3a497c62bac3f0cc47fe12d30430b2281f0d00 Reviewed By: malfet Differential Revision: D36250438 fbshipit-source-id: eb2165597b96889907e1a88bfa31fc7cdd72844e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
timeout as exit criteria
handle_exceptionfor revert workflow as well