Move ATen/core/DimVector.h to c10/util/DimVector.h.
#77045
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves `ATen/core/DimVector.h`, as suggested in: #76812 (comment) The changes can be summarized as: - Changing includes from `ATen/core/DimVector.h` to `c10/util/DimVector.h` - Re-declaring both the type and constant size in `at` namespace - Making `c10::contiguous_strides` return a `DimVector` [ghstack-poisoned]
ysiraichi
requested review from
IvanYashchuk,
lezcano and
nikitaved
as code owners
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 63ae3ec (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 8, 2022
This PR moves `ATen/core/DimVector.h`, as suggested in: #76812 (comment) The changes can be summarized as: - Changing includes from `ATen/core/DimVector.h` to `c10/util/DimVector.h` - Re-declaring both the type and constant size in `at` namespace - Making `c10::contiguous_strides` return a `DimVector` [ghstack-poisoned]
This PR moves `ATen/core/DimVector.h`, as suggested in: #76812 (comment) The changes can be summarized as: - Changing includes from `ATen/core/DimVector.h` to `c10/util/DimVector.h` - Re-declaring both the type and constant size in `at` namespace - Making `c10::contiguous_strides` return a `DimVector` [ghstack-poisoned]
|
lint |
peterbell10
requested changes
May 9, 2022
This PR moves `ATen/core/DimVector.h`, as suggested in: #76812 (comment) The changes can be summarized as: - Changing includes from `ATen/core/DimVector.h` to `c10/util/DimVector.h` - Re-declaring both the type and constant size in `at` namespace - Making `c10::contiguous_strides` return a `DimVector` [ghstack-poisoned]
…10/util/DimVector.h`." This PR moves `ATen/core/DimVector.h`, as suggested in: #76812 (comment) The changes can be summarized as: - Changing includes from `ATen/core/DimVector.h` to `c10/util/DimVector.h` - Re-declaring both the type and constant size in `at` namespace - Making `c10::contiguous_strides` return a `DimVector` [ghstack-poisoned]
This PR moves `ATen/core/DimVector.h`, as suggested in: #76812 (comment) The changes can be summarized as: - Changing includes from `ATen/core/DimVector.h` to `c10/util/DimVector.h` - Re-declaring both the type and constant size in `at` namespace - Making `c10::contiguous_strides` return a `DimVector` [ghstack-poisoned]
peterbell10
approved these changes
May 10, 2022
|
@pytorchbot merge this |
|
Merge failed due to Matched rule superuser, but it was not reviewed yet by any of:clee2000,zzzwen,guangy10,jg2912,soumith, ... |
lezcano
reviewed
May 10, 2022
Comment on lines
+12
to
15
| DimVector strides; | ||
|
|
||
| if (dims > 0) { | ||
| strides.assign(dims, 0); |
There was a problem hiding this comment.
I'd like to take this failed landing to small improvement to this code:
Suggested change
| DimVector strides; | |
| if (dims > 0) { | |
| strides.assign(dims, 0); | |
| DimVector strides(dims); | |
| if (dims > 0) { |
ezyang
approved these changes
May 11, 2022
|
@pytorchbot merge this |
|
Hey @ysiraichi. |
ysiraichi
added
release notes: cpp
facebook-github-bot
pushed a commit
that referenced
this pull request
May 13, 2022
Summary: This PR moves `ATen/core/DimVector.h`, as suggested in: #76812 (comment) The changes can be summarized as: - Changing includes from `ATen/core/DimVector.h` to `c10/util/DimVector.h` - Re-declaring both the type and constant size in `at` namespace - Making `c10::contiguous_strides` return a `DimVector` Pull Request resolved: #77045 Approved by: https://github.com/peterbell10, https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/ecde870d4e44ddb7fe2fb426666a1967826142c2 Reviewed By: atalman Differential Revision: D36322347 Pulled By: atalman fbshipit-source-id: 2fd969cdc975d6907272b677b168e2910044af9d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
set_outputfunction fromMetaBaseAPI. #76098set_outputbyset_output_raw_stridedin the codebase. #76097set_outputboilerplate with new overloads. #76096ATen/core/DimVector.htoc10/util/DimVector.h. #77045contiguous_stridestoc10/util/strides.h. #76812This PR moves
ATen/core/DimVector.h, as suggested in:#76812 (comment)
The changes can be summarized as:
ATen/core/DimVector.htoc10/util/DimVector.hatnamespacec10::contiguous_stridesreturn aDimVector