Skip to content

Latest linalg_lu revert caused bc to fail, add exceptions #77112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Latest linalg_lu revert caused bc to fail, add exceptions #77112

wants to merge 1 commit into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented May 9, 2022 •
edited
Loading

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 9, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit d13ae61 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet
Copy link
Contributor

malfet commented May 9, 2022

@pytorchbot merge this please

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

Hey @janeyx99.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@janeyx99
Copy link
Contributor Author

@pytorchbot merge this pls

@janeyx99
Copy link
Contributor Author

Oops the page didn't update

@pytorchmergebot
Copy link
Collaborator

Can't merge closed PR #77112

facebook-github-bot pushed a commit that referenced this pull request May 13, 2022
@janeyx99 @facebook-github-bot
Latest linalg_lu revert caused bc to fail, add exceptions (#77112) (#…
d9cb57d 
…77112)

Summary:
Fixes our HUD which is very red

https://hud.pytorch.org/minihud?name_filter=pull%20/%20linux-xenial-py3.7-gcc5.4%20/%20test%20(backwards_compat,%201,%201,%20linux.2xlarge)

Pull Request resolved: #77112
Approved by: https://github.com/houseroad, https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/0272aa1f1b23b97a044faf35f8d7389bf2412d91

Reviewed By: malfet

Differential Revision: D36269305

fbshipit-source-id: 7ad99f68c6888716a09ea7425cbcc36737fa229f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@houseroad houseroad houseroad approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@janeyx99 @facebook-github-bot @malfet @pytorchmergebot @houseroad