-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[JIT] handle branching tuple outputs #77120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful links
❌ 17 New Failures, 1 Flaky Failures, 1 Base FailuresAs of commit f7ea799 (more details on the Dr. CI page): Expand to see more
🕵️ 17 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
|
Looks good. I assume that the optimization passes will handle the tuple unpacking properly. |
Commandeering this diff #77120 and figuring out what issues lie with it. [ghstack-poisoned]
Commandeering this diff #77120 and figuring out what issues lie with it. [ghstack-poisoned]
Commandeering this diff #77120 and fixed the issues with it. Pull Request resolved: #83222 Approved by: https://github.com/davidberard98
Summary: Commandeering this diff #77120 and fixed the issues with it. Pull Request resolved: #83222 Approved by: https://github.com/davidberard98 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/aac317535c045cc1d52953d6e5b6dc94dec2d94d Reviewed By: atalman Differential Revision: D38658444 Pulled By: Gamrix fbshipit-source-id: ef0aabd0b6ac95d8201eea8fd19ecd8941e5e2f9
|
Closing this commit, as I have commandeered, fixed and pushed the fix here: #83222 |
tested locally with nll_loss declaration from #76889 (comment)