Skip to content

port clamp.Tensor to structured #77149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 3 commits into from
Closed

port clamp.Tensor to structured #77149

wants to merge 3 commits into from

Conversation

@ngimel
Copy link
Collaborator

@ngimel ngimel commented May 10, 2022

Per title

@ngimel ngimel requested a review from bdhirsh as a code owner May 10, 2022 06:47
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 10, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 72b6233 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 10, 2022
@ngimel ngimel requested a review from ezyang May 10, 2022 17:30
ezyang
ezyang reviewed May 10, 2022
View reviewed changes
aten/src/ATen/native/TensorCompare.cpp
.add_input(self) \
.promote_inputs_to_common_dtype(true) \
.cast_common_dtype_to_outputs(true) \
.enforce_safe_casting_to_output(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like a lambda should have worked here? Returning the config

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has C10_DISABLE_COPY_AND_ASSIGN(TensorIteratorConfig); so I didn't find the right incantation.

@ngimel
Copy link
Collaborator Author

ngimel commented May 11, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

Hey @ngimel.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@ngimel ngimel added release notes: composability release notes category topic: not user facing topic category labels May 11, 2022
facebook-github-bot pushed a commit that referenced this pull request May 13, 2022
@facebook-github-bot
port clamp.Tensor to structured (#77149) (#77149)
78d06be 
Summary:
Per title

Pull Request resolved: #77149
Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/225b037df8f9af0363459b640126ee871b396110

Reviewed By: atalman

Differential Revision: D36353620

Pulled By: atalman

fbshipit-source-id: 3b6c773ccdd52eeff9f851513e96916b67cd1dbe
@github-actions github-actions bot deleted the ngimel/clamp_structured branch February 16, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

Assignees

No one assigned

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue release notes: composability release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ngimel @facebook-github-bot @ezyang @pytorchmergebot