Skip to content

Set block dim and grid dim macros within NestedTensorTransformerFunctions.cu #77199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Set block dim and grid dim macros within NestedTensorTransformerFunctions.cu #77199

wants to merge 4 commits into from

Conversation

@cpuhrsch
Copy link
Contributor

@cpuhrsch cpuhrsch commented May 10, 2022 •
edited
Loading

Follow up to #76157 (comment)

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 10, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 14695bf (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@cpuhrsch cpuhrsch changed the title [DO NOT REVIEW] Use gridDim within NestedTensorTransformerFunctions.cu Set block dim and grid dim macros within NestedTensorTransformerFunctions.cu May 12, 2022
@cpuhrsch cpuhrsch requested a review from ngimel May 12, 2022 19:19
@cpuhrsch cpuhrsch marked this pull request as ready for review May 12, 2022 19:19
ngimel
ngimel approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, totally fell off my radar. Looks good!

@cpuhrsch
Copy link
Contributor Author

@pytorchbot merge this

@github-actions
Copy link
Contributor

Hey @cpuhrsch.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@cpuhrsch cpuhrsch added the topic: not user facing topic category label May 26, 2022
facebook-github-bot pushed a commit that referenced this pull request May 27, 2022
@cpuhrsch @facebook-github-bot
Set block dim and grid dim macros within NestedTensorTransformerFunct…
d8af852 
…ions.cu (#77199) (#77199)

Summary:
Follow up to #76157 (comment)

Pull Request resolved: #77199
Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e01fb9cd07826ca2b9fec7eb8084ca13d04adc79

Reviewed By: mehtanirav

Differential Revision: D36708019

Pulled By: cpuhrsch

fbshipit-source-id: b31277ffbe046a64f847659341e284499a15f96b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

cla signed Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cpuhrsch @facebook-github-bot @ngimel @pytorchmergebot