Skip to content

Expose permute inputs #77391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Expose permute inputs #77391

wants to merge 1 commit into from

Conversation

makslevental
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 13, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 79a516d (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 13, 2022
@makslevental
Copy link
Contributor Author

cc @Krovatkin @eellison

eellison
eellison reviewed May 13, 2022
View reviewed changes
test/test_jit.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is failing - maybe try by using a graph from a function ?

@torch.jit.script
def foo(i, j, k):
     pass

g = foo.graph

Copy link
Contributor Author

@makslevental makslevental May 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad i should've test this locally before i push. thanks for the tip

@Krovatkin
Copy link
Contributor

@pytorchbot merge this

@github-actions
Copy link
Contributor

Hey @makslevental.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request May 16, 2022
@makslevental @facebook-github-bot
Expose permute inputs (#77391) (#77391)
d804b7b 
Summary:
Pull Request resolved: #77391
Approved by: https://github.com/eellison

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/25a6aabe71553a99e1a1e2ff9425522feb46f0e2

Reviewed By: atalman

Differential Revision: D36412433

fbshipit-source-id: 91dab653bfcb2f80d92d8520a5baa1cb39c5d58f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

Assignees

No one assigned

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@makslevental @facebook-github-bot @Krovatkin @eellison @pytorchbot @pytorchmergebot