[coreml] Use special throw macro when encountering CoreML API errors #77429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

SS-JIA wants to merge 2 commits into pytorch:master from SS-JIA:export-D36378286

Contributor

SS-JIA commented May 13, 2022

Summary: Error messages from TORCH_CHECK are stripped during production builds via -DSTRIP_ERROR_MESSAGES. This diff introduces a new macro COREML_CHECK which will always preserve the error message. This macro is used when encountering errors produced by CoreML API calls so that we can heve enough context to debug.

Test Plan:
Test in pytorch playground:

arc focus2 -b pp-ios -a ModelRunner -a //xplat/caffe2/c10:c10Apple -a //xplat/caffe2:torch_mobile_coreApple  -a //xplat/caffe2/fb/dynamic_pytorch:dynamic_pytorch_implApple -a //xplat/caffe2:coreml_delegateApple  -a ModelRunnerDevOps -a //xplat/caffe2:torch_mobile_all_opsApple -fd --force-with-wrong-xcode

Differential Revision: D36378286

facebook-github-bot added the cla signed label

Contributor

facebook-github-bot commented May 13, 2022 •

edited

Loading

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/77429
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit 4ae7b75 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot added oncall: jit fb-exported labels

Contributor

facebook-github-bot commented May 13, 2022

This pull request was exported from Phabricator. Differential Revision: D36378286

SS-JIA force-pushed the export-D36378286 branch from c919f7b to f85ab09 Compare

May 13, 2022 21:21

Contributor

facebook-github-bot commented May 13, 2022

This pull request was exported from Phabricator. Differential Revision: D36378286

SS-JIA force-pushed the export-D36378286 branch from f85ab09 to d2b1113 Compare

May 14, 2022 01:06

Contributor

facebook-github-bot commented May 14, 2022

This pull request was exported from Phabricator. Differential Revision: D36378286

1 similar comment

Contributor

facebook-github-bot commented May 16, 2022

This pull request was exported from Phabricator. Differential Revision: D36378286

SS-JIA force-pushed the export-D36378286 branch from d2b1113 to 8edba43 Compare

May 16, 2022 14:04

Stephen Jia added 2 commits

May 16, 2022 07:09


          [metal] Use special throw macro when encountering Metal API errors

a13c1b6

Differential Revision: D36378285

fbshipit-source-id: 6874d768db940baa2508b9f3c2a466a0ba6e3279


          [coreml] Use special throw macro when encountering CoreML API errors (p…

4ae7b75

…ytorch#77429)

Summary:
Pull Request resolved: pytorch#77429

Error messages from `TORCH_CHECK` are stripped during production builds via  `-DSTRIP_ERROR_MESSAGES`. This diff introduces a new macro `COREML_CHECK` which will always preserve the error message. This macro is used when encountering errors produced by CoreML API calls so that we can heve enough context to debug.

Test Plan:
Test in pytorch playground:

```
arc focus2 -b pp-ios -a ModelRunner -a //xplat/caffe2/c10:c10Apple -a //xplat/caffe2:torch_mobile_coreApple  -a //xplat/caffe2/fb/dynamic_pytorch:dynamic_pytorch_implApple -a //xplat/caffe2:coreml_delegateApple  -a ModelRunnerDevOps -a //xplat/caffe2:torch_mobile_all_opsApple -fd --force-with-wrong-xcode
```

Reviewed By: kimishpatel

Differential Revision: D36378286

fbshipit-source-id: 9d0ff7029cb24b7a6387bb16047f79a17cb4d92f

Contributor

facebook-github-bot commented May 16, 2022

This pull request was exported from Phabricator. Differential Revision: D36378286

SS-JIA force-pushed the export-D36378286 branch from 8edba43 to 4ae7b75 Compare

May 16, 2022 14:12

SS-JIA requested a review from kimishpatel

May 16, 2022 15:17

kimishpatel approved these changes

View reviewed changes

Contributor

facebook-github-bot commented May 16, 2022

@pytorchbot merge this

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot added the Merged label

pytorchmergebot closed this in

93d84c0

Contributor

github-actions bot commented May 16, 2022

Hey @SS-JIA.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request


          [coreml] Use special throw macro when encountering CoreML API errors (#…

28fc166

…77429)

Summary:
Pull Request resolved: #77429

Error messages from `TORCH_CHECK` are stripped during production builds via  `-DSTRIP_ERROR_MESSAGES`. This diff introduces a new macro `COREML_CHECK` which will always preserve the error message. This macro is used when encountering errors produced by CoreML API calls so that we can heve enough context to debug.

Test Plan:
Test in pytorch playground:

```
arc focus2 -b pp-ios -a ModelRunner -a //xplat/caffe2/c10:c10Apple -a //xplat/caffe2:torch_mobile_coreApple  -a //xplat/caffe2/fb/dynamic_pytorch:dynamic_pytorch_implApple -a //xplat/caffe2:coreml_delegateApple  -a ModelRunnerDevOps -a //xplat/caffe2:torch_mobile_all_opsApple -fd --force-with-wrong-xcode
```

Reviewed By: kimishpatel

Differential Revision: D36378286

fbshipit-source-id: 193004937ac2fb2a5bb5fe79b716a172480957f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed fb-exported Merged oncall: jit