Skip to content

Saving JIT to flatbuffer should respect options. #77456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Saving JIT to flatbuffer should respect options. #77456

wants to merge 1 commit into from

Conversation

@qihqi
Copy link
Contributor

@qihqi qihqi commented May 13, 2022

Summary: title

Test Plan: manual test with T120364740

Differential Revision: D36388746

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 13, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 1c0385d (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36388746

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 13, 2022
@qihqi qihqi requested a review from pavithranrao May 13, 2022 22:09
pavithranrao
pavithranrao approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@pavithranrao pavithranrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qihqi
Copy link
Contributor Author

qihqi commented May 13, 2022

@pytorchbot merge this on green

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Refusing to merge as mandatory check(s) Lint failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2322061010

@qihqi qihqi force-pushed the export-D36388746 branch from 3e98e59 to 708e0e4 Compare May 13, 2022 22:26
@facebook-github-bot
Copy link
Contributor

@qihqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@qihqi
Saving JIT to flatbuffer should respect options.
1c0385d 
Summary: title

Test Plan: manual test with T120364740

Differential Revision: D36388746

fbshipit-source-id: 4b3b316a4cc606e33eb87bb09406a610c3ff47ef
@qihqi qihqi force-pushed the export-D36388746 branch from 708e0e4 to 1c0385d Compare May 16, 2022 15:56
@facebook-github-bot
Copy link
Contributor

@qihqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@qihqi
Copy link
Contributor Author

qihqi commented May 16, 2022

@pytorchbot merge this on green

@github-actions
Copy link
Contributor

Hey @qihqi.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@qihqi qihqi added release notes: mobile release notes category topic: bug fixes topic category labels May 16, 2022
facebook-github-bot pushed a commit that referenced this pull request May 17, 2022
@qihqi @facebook-github-bot
Saving JIT to flatbuffer should respect options. (#77456) (#77456)
764b1de 
Summary:
title

Pull Request resolved: #77456
Approved by: https://github.com/pavithranrao

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/14e59edd025963fa3968cab9d9e7ee6ddb4fbd68

Test plan from GitHub:
manual test with T120364740

Reviewed By: pavithranrao

Differential Revision: D36388746

Pulled By: qihqi

fbshipit-source-id: 21d1ac0acdef94a58af4f2009cc1a1bcb004b00f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pavithranrao pavithranrao pavithranrao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue release notes: mobile release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qihqi @facebook-github-bot @pytorchmergebot @pavithranrao