Skip to content

Save a heap allocation in embedding_bag_{byte,nbit}_impl #77564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Save a heap allocation in embedding_bag_{byte,nbit}_impl #77564

wants to merge 1 commit into from

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented May 16, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

vector that could be a stack array

Differential Revision: D36181474

@swolchok
Save a heap allocation in embedding_bag_{byte,nbit}_impl
4cbf361 
vector that could be a stack array

Differential Revision: [D36181474](https://our.internmc.facebook.com/intern/diff/D36181474/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 16, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 4cbf361 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

swolchok added a commit that referenced this pull request May 16, 2022
@swolchok
Save a heap allocation in embedding_bag_{byte,nbit}_impl
03b34c1 
vector that could be a stack array

Differential Revision: [D36181474](https://our.internmc.facebook.com/intern/diff/D36181474/)

ghstack-source-id: 156433477
Pull Request resolved: #77564
@swolchok
Copy link
Contributor Author

@pytorchbot merge this please

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Matched rule superuser, but PR has not been reviewed yet
Raised by https://github.com/pytorch/pytorch/actions/runs/2359661709

@swolchok swolchok requested review from dzdang, hlu1, jianyuh and supriyar May 25, 2022 20:57
jianyuh
jianyuh approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@jianyuh jianyuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swolchok
Copy link
Contributor Author

@pytorchbot merge

@github-actions
Copy link
Contributor

Hey @swolchok.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@swolchok swolchok added the topic: not user facing topic category label Jun 1, 2022
facebook-github-bot pushed a commit that referenced this pull request Jun 1, 2022
@swolchok @facebook-github-bot
Save a heap allocation in embedding_bag_{byte,nbit}_impl (#77564)
f3b7850 
Summary:
vector that could be a stack array

Pull Request resolved: #77564

Approved by: https://github.com/jianyuh

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/050e416f40cb4648ee28b78c7f574be97efa6bb8

Reviewed By: seemethere, jianyuh

Differential Revision: D36181474

Pulled By: swolchok

fbshipit-source-id: fb6a0dcc0bd870601cc609f7f89e94b588a2d6b6
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/513/head branch June 4, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jianyuh jianyuh jianyuh approved these changes

@dzdang dzdang Awaiting requested review from dzdang

@supriyar supriyar Awaiting requested review from supriyar

@hlu1 hlu1 Awaiting requested review from hlu1

Assignees

No one assigned

Labels

cla signed Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @facebook-github-bot @pytorchmergebot @jianyuh