Add option to disable autocast pass #77566
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful links
❌ 4 New FailuresAs of commit 7b7a39e (more details on the Dr. CI page): Expand to see more
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
facebook-github-bot
added
the
oncall: jit
anijain2305
approved these changes
May 16, 2022
davidberard98
approved these changes
May 16, 2022
|
|
||
| // if invoked on a graph that has already traced through amp | ||
| // don't invoke amp pass | ||
| mutable bool force_no_amp_ = false; |
There was a problem hiding this comment.
does this need to be mutable?
There was a problem hiding this comment.
i think so otherwise all the const stuff wont compile
| "name", | ||
| [](const StrongFunctionPtr& self) { return self.function_->name(); }) | ||
| .def( | ||
| "_set_ignore_amp", |
There was a problem hiding this comment.
do we need anything like this for modules?
There was a problem hiding this comment.
no, since the use case here is just aot autograd
|
@pytorchbot merge this pleasee |
|
Hey @eellison. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 20, 2022
Summary: Pull Request resolved: #77566 Approved by: https://github.com/anijain2305, https://github.com/davidberard98 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/05ce0f9be63dd6fadd2fb40c29f8f867f267002b Reviewed By: seemethere Differential Revision: D36494147 Pulled By: seemethere fbshipit-source-id: c09a25d1b606e54646e5d12a6c961f91f26b215e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fix for AOT autograd, where amp has already been traced out and you don't want to re-invoke the amp pass.
cc @anijain2305, @Chillee