Skip to content

Conversation

@bdhirsh
Copy link
Contributor

@bdhirsh bdhirsh commented May 16, 2022

After adding the at::lift op, it started getting traced during torch.jit.trace. We don't want that to happen for BC reasons

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 16, 2022

🔗 Helpful links

❌ 1 New Failures

As of commit 8d3f51e (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-rocm5.1-py3.7 / test (default, 1, 2, linux.rocm.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-16T20:56:48.4031390Z RuntimeError: test_prims failed!
2022-05-16T20:56:44.8610708Z FAILED (errors=1, expected failures=3)
2022-05-16T20:56:44.8610763Z 
2022-05-16T20:56:44.8610885Z Generating XML reports...
2022-05-16T20:56:44.8611250Z Generated XML report: test-reports/python-unittest/test_prims/TEST-TestPrimsBasic-20220516205643.xml
2022-05-16T20:56:44.8611711Z Generated XML report: test-reports/python-unittest/test_prims/TEST-TestPrimsCUDA-20220516205643.xml
2022-05-16T20:56:46.5676212Z Traceback (most recent call last):
2022-05-16T20:56:46.5677092Z   File "test/run_test.py", line 1072, in <module>
2022-05-16T20:56:46.5680746Z     main()
2022-05-16T20:56:46.5681427Z   File "test/run_test.py", line 1050, in main
2022-05-16T20:56:46.5687137Z     raise RuntimeError(err_message)
2022-05-16T20:56:48.4031390Z RuntimeError: test_prims failed!
2022-05-16T20:56:48.4032014Z 
2022-05-16T20:56:48.4032330Z real	5m36.300s
2022-05-16T20:56:48.4033129Z user	22m20.652s
2022-05-16T20:56:48.4033857Z sys	3m21.534s
2022-05-16T20:56:48.4035015Z + cleanup
2022-05-16T20:56:48.4035685Z + retcode=1
2022-05-16T20:56:48.4036250Z + set +x
2022-05-16T20:56:48.4138063Z ##[error]Process completed with exit code 1.
2022-05-16T20:56:48.4225559Z ##[group]Run # copy test results back to the mounted workspace, needed sudo, resulting permissions were correct
2022-05-16T20:56:48.4226983Z �[36;1m# copy test results back to the mounted workspace, needed sudo, resulting permissions were correct�[0m

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

@bdhirsh has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@bdhirsh bdhirsh requested a review from ezyang May 16, 2022 21:41
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge this

(Initiating merge automatically since Phabricator Diff has merged)

@github-actions
Copy link
Contributor

Hey @bdhirsh.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request May 17, 2022
Summary:
After adding the `at::lift` op, it started getting traced during `torch.jit.trace`. We don't want that to happen for BC reasons

Pull Request resolved: #77588

Reviewed By: ezyang

Differential Revision: D36423018

Pulled By: bdhirsh

fbshipit-source-id: 0099ce6fbce5a97c980a0c3374b1c239fc7806da
}

// torch.jit.trace will continue to trace out `.to()` instead of `.lift()`, since
// changing it is BC-breaking.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we should actually change this message to be FC breaking, because we can change in 2 weeks if we wanted to right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's right

@github-actions github-actions bot deleted the fix_lift_tracing2 branch February 16, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants