Skip to content

Static initializer update #78052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Static initializer update #78052

wants to merge 2 commits into from

Conversation

@jjsjann123
Copy link
Collaborator

Code cleaning, call_once on a static initializer shouldn't be needed.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 21, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit b50f82b (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 21, 2022
@mrshenli mrshenli added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 22, 2022
@mrshenli mrshenli requested a review from suo May 22, 2022 22:17
suo
suo approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@suo suo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@suo
Copy link
Member

suo commented May 22, 2022

@pytorchbot merge

@github-actions
Copy link
Contributor

Hey @jjsjann123.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request May 24, 2022
@jjsjann123 @facebook-github-bot
Static initializer update (#78052) (#78052)
4439ba1 
Summary:
Code cleaning, call_once on a static initializer shouldn't be needed.

Pull Request resolved: #78052
Approved by: https://github.com/suo

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/735ab791684581cd800da2807a635b1f486f8a67

Reviewed By: seemethere

Differential Revision: D36603480

Pulled By: seemethere

fbshipit-source-id: 9b6da82276478eb522b8ce75141be6ef787187e7
swang392 pushed a commit that referenced this pull request May 25, 2022
@jjsjann123 @swang392
Static initializer update (#78052)
e4a741c 
Code cleaning, call_once on a static initializer shouldn't be needed.
Pull Request resolved: #78052
Approved by: https://github.com/suo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suo suo suo approved these changes

Assignees

No one assigned

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jjsjann123 @facebook-github-bot @suo @mrshenli @pytorchbot @pytorchmergebot