Skip to content

[primTorch] refs: masked_fill #78132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 18 commits into from
Closed

[primTorch] refs: masked_fill #78132

wants to merge 18 commits into from

Conversation

@kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented May 23, 2022 •
edited
Loading

TODO

  • Add error inputs

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 23, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit f360936 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@kshitij12345 kshitij12345 marked this pull request as ready for review June 9, 2022 10:39
@kshitij12345
Copy link
Collaborator Author

NOTE: nvFuser failure is real.

mruberry
mruberry reviewed Jun 9, 2022
View reviewed changes
mruberry
mruberry reviewed Jun 9, 2022
View reviewed changes
mruberry
mruberry reviewed Jun 9, 2022
View reviewed changes
mruberry
mruberry approved these changes Jun 9, 2022
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but see inline suggestions for review

@kshitij12345
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @kshitij12345.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 13, 2022
@kshitij12345 @facebook-github-bot
[primTorch] refs: masked_fill (#78132) (#78132)
615ca01 
Summary:
TODO

* [x] Add error inputs

Pull Request resolved: #78132
Approved by: https://github.com/mruberry

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/3d77017674aa538711515cf606435446ca9113b5

Reviewed By: osalpekar

Differential Revision: D37085560

Pulled By: osalpekar

fbshipit-source-id: b3fe7b947a3a9202e2ddd2f790562d550b0791d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kshitij12345 @facebook-github-bot @pytorchmergebot @mruberry @pytorchbot