Skip to content

update xla commit - check for exist pr #78156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 3 commits into from
Closed

update xla commit - check for exist pr #78156

wants to merge 3 commits into from

Conversation

@clee2000
Copy link
Contributor

as in title, check for existing pr, if exists -> update that pr, if not exist -> make new pr

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 24, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 62b8628 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@clee2000 clee2000 marked this pull request as ready for review May 24, 2022 02:52
janeyx99
janeyx99 reviewed May 24, 2022
View reviewed changes
.github/workflows/update-xla-commit-hash.yml Outdated
with:
fetch-depth: 1
submodules: false
token: ${{ secrets.PAT }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you already add this secret to our repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@clee2000 clee2000 requested a review from a team as a code owner May 24, 2022 15:36
@clee2000 clee2000 requested a review from janeyx99 May 24, 2022 15:40
malfet
malfet approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please elaborate why mergebot rather than standard github token needs to be used here?

.github/workflows/update-xla-commit-hash.yml
with:
fetch-depth: 1
submodules: false
token: ${{ secrets.MERGEBOT_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, can we use a github token instead?

Suggested change
token: ${{ secrets.MERGEBOT_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you push using the github token, it doesnt retrigger workflows
https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow

@clee2000
Copy link
Contributor Author

@pytorchbot merge

@github-actions
Copy link
Contributor

Hey @clee2000.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request May 25, 2022
@clee2000 @facebook-github-bot
update xla commit - check for exist pr (#78156) (#78156)
f644f0a 
Summary:
as in title, check for existing pr, if exists -> update that pr, if not exist -> make new pr

Pull Request resolved: #78156
Approved by: https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/331629046d2da10b0716882ed4c480408024ee78

Reviewed By: mehtanirav

Differential Revision: D36668392

Pulled By: clee2000

fbshipit-source-id: e99fa53c909fd2226d4ad131a9a9c954035b043d
@clee2000 clee2000 deleted the clee2000/xla-pr branch June 3, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@seemethere seemethere Awaiting requested review from seemethere

@atalman atalman Awaiting requested review from atalman

@janeyx99 janeyx99 Awaiting requested review from janeyx99

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@clee2000 @facebook-github-bot @malfet @janeyx99 @pytorchmergebot