Mark more methods of DispatchKeySet as constexpr #78558
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added operator-, DispatchKeySet::add, and DispatchKeySet::remove. I wanted to use these in functorch to make a constexpr DispatchKeySet. Also adds C10_NODISCARD to DispatchKeySet::remove to make it consistent with DispatchKeySet::add (this will raise a warning if someone calls remove without assigning the result to a variable; remove is NOT mutable and this is a pitfall that I run into a lot) Test Plan: - wait for tests [ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit f61bb43 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
zou3519
added a commit
that referenced
this pull request
May 31, 2022
Added operator-, DispatchKeySet::add, and DispatchKeySet::remove. I wanted to use these in functorch to make a constexpr DispatchKeySet. Also adds C10_NODISCARD to DispatchKeySet::remove to make it consistent with DispatchKeySet::add (this will raise a warning if someone calls remove without assigning the result to a variable; remove is NOT mutable and this is a pitfall that I run into a lot) Test Plan: - wait for tests ghstack-source-id: f2b030a Pull Request resolved: #78558
|
@pytorchbot merge this please |
|
Hey @zou3519. |
bigfootjon
pushed a commit
that referenced
this pull request
Jun 2, 2022
Summary: Added operator-, DispatchKeySet::add, and DispatchKeySet::remove. I wanted to use these in functorch to make a constexpr DispatchKeySet. Also adds C10_NODISCARD to DispatchKeySet::remove to make it consistent with DispatchKeySet::add (this will raise a warning if someone calls remove without assigning the result to a variable; remove is NOT mutable and this is a pitfall that I run into a lot) Pull Request resolved: #78558 Approved by: https://github.com/bdhirsh Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/de5a2320f26f542a9e5a1999cf4917e9796a44f2 Test plan from GitHub: - wait for tests Reviewed By: b0noI Differential Revision: D36854229 Pulled By: zou3519 fbshipit-source-id: 1fef207153409b6978bff9b3da5e969c84db6fc0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Added operator- and DispatchKeySet::add.
I wanted to use these in functorch to make a constexpr DispatchKeySet.
Also adds C10_NODISCARD to DispatchKeySet::remove to make it
consistent with DispatchKeySet::add (this will raise a
warning if someone calls remove without assigning the result to a
variable; remove is NOT mutable and this is a pitfall that I run into a
lot)
Test Plan: