-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[Checkpoint] Test file for checkpoint_wrapper #78702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 22f044b (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to keep test_checkpoint_wrapper.py in test/distributed/fsdp/ in the short-term and relocate it in the long term?
|
@awgu Yes, Although agreed it is not ideal to have 2 test files of the same name due to confusion, that one can probably be named |
|
@pytorchbot merge |
|
Merge failed due to Refusing to merge as mandatory check(s) Lint failed for rule superuser |
As we make additional changes and don't couple checkpoint_wrapper with FSDP, would be good to have standalone test file for it. Currently, we port the only non FSDP specific unittest that exists, and will add more as development continues. [ghstack-poisoned]
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @rohan-varma. |
Summary: Pull Request resolved: #78702 Approved by: https://github.com/awgu Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/fb02acef1fceddd6942e72c809bdc77c8b53dd73 Reviewed By: seemethere, b0noI Differential Revision: D36914859 Pulled By: rohan-varma fbshipit-source-id: 54e9b0b8c7bea62e1e000912120fa3bbe444de94
Stack from ghstack (oldest at bottom):
As we make additional changes and don't couple checkpoint_wrapper with
FSDP, would be good to have standalone test file for it.
Currently, we port the only non FSDP specific unittest that exists, and will add more as development continues.