Skip to content

Conversation

@rohan-varma
Copy link
Contributor

@rohan-varma rohan-varma commented Jun 2, 2022

Stack from ghstack (oldest at bottom):

As we make additional changes and don't couple checkpoint_wrapper with
FSDP, would be good to have standalone test file for it.

Currently, we port the only non FSDP specific unittest that exists, and will add more as development continues.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 2, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 22f044b (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Jun 2, 2022
rohan-varma added a commit that referenced this pull request Jun 2, 2022
ghstack-source-id: 05d2033
Pull Request resolved: #78702
Copy link
Collaborator

@awgu awgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to keep test_checkpoint_wrapper.py in test/distributed/fsdp/ in the short-term and relocate it in the long term?

@awgu awgu self-requested a review June 2, 2022 22:34
@rohan-varma
Copy link
Contributor Author

@awgu Yes, test_checkpoint_wrapper.py in fsdp tests tests integration / interaction with FSDP as that is a very common use case.

Although agreed it is not ideal to have 2 test files of the same name due to confusion, that one can probably be named test_checkpoint_wrapper_with_fsdp which I'll do in a follow up.

@rohan-varma
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Refusing to merge as mandatory check(s) Lint failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2435959380

As we make additional changes and don't couple checkpoint_wrapper with
FSDP, would be good to have standalone test file for it.

Currently, we port the only non FSDP specific unittest that exists, and will add more as development continues.

[ghstack-poisoned]
@rohan-varma
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

Hey @rohan-varma.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 6, 2022
Summary:
Pull Request resolved: #78702

Approved by: https://github.com/awgu

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/fb02acef1fceddd6942e72c809bdc77c8b53dd73

Reviewed By: seemethere, b0noI

Differential Revision: D36914859

Pulled By: rohan-varma

fbshipit-source-id: 54e9b0b8c7bea62e1e000912120fa3bbe444de94
@facebook-github-bot facebook-github-bot deleted the gh/rohan-varma/564/head branch June 7, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants