Skip to content

Fix tests that were never running, add a new test #78843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix tests that were never running, add a new test #78843

wants to merge 1 commit into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Jun 3, 2022 •
edited
Loading

@ezyang
Fix tests that were never running, add a new test
8380208 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Jun 3, 2022
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 3, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 8380208 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@ezyang ezyang requested review from eellison and samdow June 3, 2022 20:59
samdow
samdow reviewed Jun 3, 2022
View reviewed changes
test/test_overrides.py
torch.abs(a)

@skipIfCrossRef
@unittest.skipIf(TEST_WITH_CROSSREF, "not run with crossref")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from skipIfCrossRef?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently skipIfCrossRef doesn't work when applied to an entire test class

samdow
samdow approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@samdow samdow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Stuff like this is making me think though to Richard's point on an earlier PR that I want to unify the tests but that can come later

@ezyang
Copy link
Contributor Author

ezyang commented Jun 4, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2022

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 6, 2022
@ezyang @facebook-github-bot
Fix tests that were never running, add a new test (#78843)
52f8e32 
Summary:
Signed-off-by: Edward Z. Yang <ezyangfb.com>

Pull Request resolved: #78843

Approved by: https://github.com/samdow

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/7860ce5b79f28d601f31aeade400d9873137fee4

Reviewed By: seemethere

Differential Revision: D36935430

Pulled By: ezyang

fbshipit-source-id: 781a33e3413679edd36066aa59907c889d189866
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1200/head branch June 7, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison Awaiting requested review from eellison

1 more reviewer

@samdow samdow samdow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @facebook-github-bot @pytorchmergebot @samdow