Skip to content

Revert "Revert "moved logit to use torch ops instead of refs + added …a couple more decompositions"" #79082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 1 commit into from
Closed

Revert "Revert "moved logit to use torch ops instead of refs + added …a couple more decompositions"" #79082

wants to merge 1 commit into from

Conversation

@Chillee
Copy link
Collaborator

@Chillee Chillee commented Jun 7, 2022

@pytorchmergebot @Chillee
Revert "Revert "moved logit to use torch ops instead of refs + added …
1d90b9a 
…a couple more decompositions""

This reverts commit 7d192d4.
@Chillee Chillee requested a review from osalpekar June 7, 2022 23:36
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 7, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 1d90b9a (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@Chillee Chillee requested a review from ezyang June 7, 2022 23:45
eellison
eellison approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@Chillee
Copy link
Collaborator Author

Chillee commented Jun 7, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Hey @Chillee.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

davidchencsl pushed a commit that referenced this pull request Jun 8, 2022
@pytorchmergebot @davidchencsl
Revert "Revert "moved logit to use torch ops instead of refs + added …
c79d16f 
……a couple more decompositions"" (#79082)

cc: @osalpekar
Pull Request resolved: #79082
Approved by: https://github.com/eellison
facebook-github-bot pushed a commit that referenced this pull request Jun 8, 2022
@pytorchmergebot @facebook-github-bot
Revert "Revert "moved logit to use torch ops instead of refs + added …
60ba5e0 
……a couple more decompositions"" (#79082) (#79082)

Summary:
GitHub CC:
osalpekar

Pull Request resolved: #79082
Approved by: https://github.com/eellison

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8ce310b943bc6277f5e63d6bd52d93b2a5bb2212

Reviewed By: osalpekar

Differential Revision: D37010589

Pulled By: osalpekar

fbshipit-source-id: 0d6243e3f72c631a9b7438cb7e4bc34ebd452906
@github-actions github-actions bot deleted the reland_logit branch February 16, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

@osalpekar osalpekar Awaiting requested review from osalpekar

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Chillee @facebook-github-bot @pytorchmergebot @eellison