-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Do not treat all dense tensors as isTensorSubclassLike #79098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes #79079 Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
🔗 Helpful links
❌ 1 New FailuresAs of commit 9177aa5 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
Fixes #79079 Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
Fixes #79079 Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
Fixes #79079 Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
Fixes #79079 Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
@pytorchbot merge |
@pytorchbot successfully started a merge job. Check the current status here |
Merge failed due to Command
Raised by https://github.com/pytorch/pytorch/actions/runs/2465208500 |
Fixes #79079 Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
Fixes #79079 Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
@pytorchbot merge -g |
@pytorchbot successfully started a merge job. Check the current status here |
Hey @ezyang. |
Summary: Fixes #79079 Signed-off-by: Edward Z. Yang <ezyangfb.com> Pull Request resolved: #79098 Approved by: https://github.com/soulitzer, https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/eb856daf0f53f4709121f2cc8486a8f352ef75f1 To regen the model.yaml file ``` cd ~/fbsource/fbcode && buck run caffe2/torch/fb/mobile/cli:cli -- --gen_model_config --model_name fl_sample_smart_keyboard --model_version 1 --asset_name model ``` Reviewed By: pavithranrao Differential Revision: D37030351 Pulled By: JacobSzwejbka fbshipit-source-id: 7e7d33044b233273709c2b4ebfb8eb6684dfa189
Stack from ghstack (oldest at bottom):
Fixes #79079
Signed-off-by: Edward Z. Yang ezyang@fb.com