Skip to content

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Jun 8, 2022

Stack from ghstack (oldest at bottom):

Fixes #79079

Signed-off-by: Edward Z. Yang ezyang@fb.com

Fixes #79079

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 8, 2022

🔗 Helpful links

❌ 1 New Failures

As of commit 9177aa5 (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-xenial-cuda11.3-py3.7-gcc7 / test (default, 3, 4, linux.4xlarge.nvidia.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-06-09T04:09:36.3937771Z RuntimeError: test_modules failed!
2022-06-09T04:09:35.6760846Z 
2022-06-09T04:09:35.6761054Z FAILED (errors=3, skipped=565, expected failures=12, unexpected successes=3)
2022-06-09T04:09:35.6761302Z 
2022-06-09T04:09:35.6761433Z Generating XML reports...
2022-06-09T04:09:35.7829260Z Generated XML report: test-reports/python-unittest/test_modules/TEST-TestModuleCUDA-20220609040857.xml
2022-06-09T04:09:36.3931469Z Traceback (most recent call last):
2022-06-09T04:09:36.3931883Z   File "test/run_test.py", line 1077, in <module>
2022-06-09T04:09:36.3934405Z     main()
2022-06-09T04:09:36.3934686Z   File "test/run_test.py", line 1055, in main
2022-06-09T04:09:36.3937353Z     raise RuntimeError(err_message)
2022-06-09T04:09:36.3937771Z RuntimeError: test_modules failed!
2022-06-09T04:09:36.9387408Z + cleanup
2022-06-09T04:09:36.9387705Z + retcode=1
2022-06-09T04:09:36.9387972Z + set +x
2022-06-09T04:09:36.9439392Z ##[error]Process completed with exit code 1.
2022-06-09T04:09:36.9489498Z ##[group]Run pytorch/pytorch/.github/actions/get-workflow-job-id@master
2022-06-09T04:09:36.9489893Z with:
2022-06-09T04:09:36.9490477Z   github-token: ***
2022-06-09T04:09:36.9490708Z env:
2022-06-09T04:09:36.9490932Z   IN_CI: 1
2022-06-09T04:09:36.9491164Z   IS_GHA: 1

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@ezyang ezyang requested review from albanD, bdhirsh and soulitzer June 8, 2022 01:25
Fixes #79079

Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
Fixes #79079

Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 8, 2022
Fixes #79079

Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: 64c1291
Pull Request resolved: #79098
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Fixes #79079

Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 8, 2022
Fixes #79079

Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: 5540a2e
Pull Request resolved: #79098
Fixes #79079

Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 8, 2022
Fixes #79079

Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: f082937
Pull Request resolved: #79098
@ezyang
Copy link
Contributor Author

ezyang commented Jun 9, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Command git -C /home/runner/actions-runner/_work/pytorch/pytorch cherry-pick -x fb53d3da43f64f2be0c632679655149fd64e9061 returned non-zero exit code 1

Auto-merging test/test_profiler.py
CONFLICT (content): Merge conflict in test/test_profiler.py
error: could not apply fb53d3da43... Do not treat all dense tensors as isTensorSubclassLike
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Raised by https://github.com/pytorch/pytorch/actions/runs/2465208500

Fixes #79079

Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
Fixes #79079

Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jun 9, 2022
Fixes #79079

Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: c4f841c
Pull Request resolved: #79098
@ezyang
Copy link
Contributor Author

ezyang commented Jun 9, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 10, 2022
Summary:
Fixes #79079

Signed-off-by: Edward Z. Yang <ezyangfb.com>

Pull Request resolved: #79098

Approved by: https://github.com/soulitzer, https://github.com/albanD

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/eb856daf0f53f4709121f2cc8486a8f352ef75f1

To regen the model.yaml file
```
cd ~/fbsource/fbcode && buck run caffe2/torch/fb/mobile/cli:cli -- --gen_model_config --model_name fl_sample_smart_keyboard --model_version 1 --asset_name model

```

Reviewed By: pavithranrao

Differential Revision: D37030351

Pulled By: JacobSzwejbka

fbshipit-source-id: 7e7d33044b233273709c2b4ebfb8eb6684dfa189
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1212/head branch June 12, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants