Skip to content

Conversation

@fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Jun 11, 2022

Stack from ghstack (oldest at bottom):

During the debugging for TP enablement for Transformer model, looks like Partial tensor does not use its own pg during resharding while using the default pg instead. Switch to use its own pg as the fix.

Differential Revision: D37093468

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 11, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 0e7e424 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Jun 11, 2022
…omm will be enabled during reshard"

[ghstack-poisoned]
fduwjj added a commit that referenced this pull request Jun 12, 2022
… enabled during reshard

ghstack-source-id: 87acffc
Pull Request resolved: #79357
@fduwjj
Copy link
Contributor Author

fduwjj commented Jun 12, 2022

@fduwjj has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@fduwjj fduwjj requested a review from wanchaol June 12, 2022 00:43
@fduwjj
Copy link
Contributor Author

fduwjj commented Jun 14, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @fduwjj.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 16, 2022
… enabled during reshard (#79357)

Summary:
Pull Request resolved: #79357

Approved by: https://github.com/wanchaol

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f4edbaa62fcc1dc60066bb95926f8a578d8c351e

Reviewed By: wanchaol

Differential Revision: D37093468

Pulled By: fduwjj

fbshipit-source-id: 1eff1b1c727b406308029c7ea22b2903d6d61b23
@facebook-github-bot facebook-github-bot deleted the gh/fduwjj/27/head branch June 18, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (sharded) release notes category sharded_tensor topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants