Support non-standard bools in CUDA masked_scatter #79391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failure comes from within the `exclusive_sum` used to calculate the selection index. So, I merged the code paths for `uint8_t` and `bool` masks together, then use `cub::TransformIterator` to get a proper `bool` value for the result. [ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit afdb51a (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jun 13, 2022
…_scatter CUDA" The failure comes from within the `exclusive_sum` used to calculate the selection index. So, I merged the code paths for `uint8_t` and `bool` masks together, then use `cub::TransformIterator` to get a proper `bool` value for the result. [ghstack-poisoned]
The failure comes from within the `exclusive_sum` used to calculate the selection index. So, I merged the code paths for `uint8_t` and `bool` masks together, then use `cub::TransformIterator` to get a proper `bool` value for the result. [ghstack-poisoned]
…ked_scatter CUDA" The failure comes from within the `exclusive_sum` used to calculate the selection index. So, I merged the code paths for `uint8_t` and `bool` masks together, then use `cub::TransformIterator` to get a proper `bool` value for the result. [ghstack-poisoned]
The failure comes from within the `exclusive_sum` used to calculate the selection index. So, I merged the code paths for `uint8_t` and `bool` masks together, then use `cub::TransformIterator` to get a proper `bool` value for the result. [ghstack-poisoned]
The failure comes from within the `exclusive_sum` used to calculate the selection index. So, I merged the code paths for `uint8_t` and `bool` masks together, then use `cub::TransformIterator` to get a proper `bool` value for the result. [ghstack-poisoned]
The failure comes from within the `exclusive_sum` used to calculate the selection index. So, I merged the code paths for `uint8_t` and `bool` masks together, then use `cub::TransformIterator` to get a proper `bool` value for the result. [ghstack-poisoned]
The failure comes from within the `exclusive_sum` used to calculate the selection index. So, I merged the code paths for `uint8_t` and `bool` masks together, then use `cub::TransformIterator` to get a proper `bool` value for the result. [ghstack-poisoned]
mruberry
approved these changes
Jun 21, 2022
mikaylagawarecki
approved these changes
Jun 21, 2022
The failure comes from within the `exclusive_sum` used to calculate the selection index. So, I merged the code paths for `uint8_t` and `bool` masks together, then use `cub::TransformIterator` to get a proper `bool` value for the result. [ghstack-poisoned]
The failure comes from within the `exclusive_sum` used to calculate the selection index. So, I merged the code paths for `uint8_t` and `bool` masks together, then use `cub::TransformIterator` to get a proper `bool` value for the result. [ghstack-poisoned]
peterbell10
changed the title
The failure comes from within the `exclusive_sum` used to calculate the selection index. So, I merged the code paths for `uint8_t` and `bool` masks together, then use `cub::TransformIterator` to get a proper `bool` value for the result. [ghstack-poisoned]
|
@pytorchbot merge -g |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @peterbell10. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 5, 2022
Summary: The failure comes from within the `exclusive_sum` used to calculate the selection index. So, I merged the code paths for `uint8_t` and `bool` masks together, then use `cub::TransformIterator` to get a proper `bool` value for the result. Pull Request resolved: #79391 Approved by: https://github.com/mruberry, https://github.com/mikaylagawarecki Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/a620512d4ba4fa21084ea9fbfb4725b24dd63269 Reviewed By: b0noI Differential Revision: D37578897 fbshipit-source-id: eae0fb76bd6f1186d7e6451d7983897812a093cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The failure comes from within the
exclusive_sumused to calculatethe selection index. So, I merged the code paths for
uint8_tandboolmasks together, then usecub::TransformIteratorto get aproper
boolvalue for the result.