Skip to content

Conversation

@macandro96
Copy link

@macandro96 macandro96 commented Jun 13, 2022

Stack from ghstack (oldest at bottom):

The state of the data sparsifier object contains the name->mask mapping, name -> config mapping and the state_dict() of the container.
The load_state_dict() and set_state() automatically creates a container moduie and loads the named data internally without having the user to intervene.

Test Plan:
python test/test_ao_sparsity.py TestBaseDataSparsifier

Differential Revision: D37164117

The state of the data sparsifier object contains the name->mask mapping, name -> config mapping and the state_dict() of the container.
The load_state_dict() and __set_state__() automatically creates a container moduie and loads the named data internally without having the user to intervene.

Test Plan:
```python test/test_ao_sparsity.py TestBaseDataSparsifier```

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 13, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 6cdae31 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

macandro96 added 2 commits June 13, 2022 18:46
…nctionalities"

The state of the data sparsifier object contains the name->mask mapping, name -> config mapping and the state_dict() of the container.
The load_state_dict() and __set_state__() automatically creates a container moduie and loads the named data internally without having the user to intervene.

Test Plan:
```python test/test_ao_sparsity.py TestBaseDataSparsifier```

[ghstack-poisoned]
…nctionalities"

The state of the data sparsifier object contains the name->mask mapping, name -> config mapping and the state_dict() of the container.
The load_state_dict() and __set_state__() automatically creates a container moduie and loads the named data internally without having the user to intervene.

Test Plan:
```python test/test_ao_sparsity.py TestBaseDataSparsifier```

[ghstack-poisoned]
macandro96 added 2 commits June 14, 2022 22:02
…nctionalities"

The state of the data sparsifier object contains the name->mask mapping, name -> config mapping and the state_dict() of the container.
The load_state_dict() and __set_state__() automatically creates a container moduie and loads the named data internally without having the user to intervene.

Test Plan:
```python test/test_ao_sparsity.py TestBaseDataSparsifier```

[ghstack-poisoned]
…nctionalities"

The state of the data sparsifier object contains the name->mask mapping, name -> config mapping and the state_dict() of the container.
The load_state_dict() and __set_state__() automatically creates a container moduie and loads the named data internally without having the user to intervene.

Test Plan:
```python test/test_ao_sparsity.py TestBaseDataSparsifier```

[ghstack-poisoned]
Copy link

@z-a-f z-a-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

macandro96 added 3 commits June 14, 2022 23:57
…nctionalities"

The state of the data sparsifier object contains the name->mask mapping, name -> config mapping and the state_dict() of the container.
The load_state_dict() and __set_state__() automatically creates a container moduie and loads the named data internally without having the user to intervene.

Test Plan:
```python test/test_ao_sparsity.py TestBaseDataSparsifier```

[ghstack-poisoned]
…nctionalities"

The state of the data sparsifier object contains the name->mask mapping, name -> config mapping and the state_dict() of the container.
The load_state_dict() and __set_state__() automatically creates a container moduie and loads the named data internally without having the user to intervene.

Test Plan:
```python test/test_ao_sparsity.py TestBaseDataSparsifier```

[ghstack-poisoned]
…nctionalities"

The state of the data sparsifier object contains the name->mask mapping, name -> config mapping and the state_dict() of the container.
The load_state_dict() and __set_state__() automatically creates a container moduie and loads the named data internally without having the user to intervene.

Test Plan:
```python test/test_ao_sparsity.py TestBaseDataSparsifier```

[ghstack-poisoned]
@macandro96
Copy link
Author

@macandro96 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…nctionalities"

The state of the data sparsifier object contains the name->mask mapping, name -> config mapping and the state_dict() of the container.
The load_state_dict() and __set_state__() automatically creates a container moduie and loads the named data internally without having the user to intervene.

Test Plan:
```python test/test_ao_sparsity.py TestBaseDataSparsifier```

Differential Revision: [D37164117](https://our.internmc.facebook.com/intern/diff/D37164117)

[ghstack-poisoned]
@macandro96
Copy link
Author

@macandro96 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…nctionalities"

The state of the data sparsifier object contains the name->mask mapping, name -> config mapping and the state_dict() of the container.
The load_state_dict() and __set_state__() automatically creates a container moduie and loads the named data internally without having the user to intervene.

Test Plan:
```python test/test_ao_sparsity.py TestBaseDataSparsifier```

Differential Revision: [D37164117](https://our.internmc.facebook.com/intern/diff/D37164117)

[ghstack-poisoned]
@macandro96
Copy link
Author

@macandro96 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @macandro96.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 16, 2022
…es (#79427)

Summary:
Pull Request resolved: #79427

The state of the data sparsifier object contains the name->mask mapping, name -> config mapping and the state_dict() of the container.
The load_state_dict() and __set_state__() automatically creates a container moduie and loads the named data internally without having the user to intervene.

Test Plan: ```python test/test_ao_sparsity.py TestBaseDataSparsifier```

Reviewed By: jerryzh168

Differential Revision: D37164117

Pulled By: macandro96

fbshipit-source-id: 0696800d64c76fa943ed1fe4ac3e24d491cf8fbd
@facebook-github-bot facebook-github-bot deleted the gh/macandro96/6/head branch June 20, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants