Skip to content

[JIT] Change SchemaCheckTensor into SchemaCheckMode and fix global variable issues #79473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[JIT] Change SchemaCheckTensor into SchemaCheckMode and fix global variable issues #79473

wants to merge 1 commit into from

Conversation

ttanpcs
Copy link

@ttanpcs ttanpcs commented Jun 13, 2022 •
edited
Loading

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 13, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 6d5129f (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 13, 2022
@ttanpcs ttanpcs mentioned this pull request Jun 13, 2022
Closed
@davidberard98 davidberard98 requested a review from eellison June 14, 2022 00:00
eellison
eellison approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

torch/testing/_internal/schema_check_mode.py

def __torch_dispatch__(self, func, types, args=(), kwargs=None):
def has_mutated(before, after):
return not torch.equal(before, after) if isinstance(before, torch.Tensor) and isinstance(after, torch.Tensor) else False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we deepcopy before ? (unrelated to refactor)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we deepcopy before. (Although I'm not entirely sure if that's what you are asking here)

@ttanpcs ttanpcs mentioned this pull request Jun 15, 2022
Closed
@ttanpcs
Copy link
Author

ttanpcs commented Jun 15, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @goldenxuett.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@ttanpcs ttanpcs mentioned this pull request Jun 16, 2022
Closed
@facebook-github-bot facebook-github-bot deleted the gh/goldenxuett/7/head branch June 19, 2022 14:16
facebook-github-bot pushed a commit that referenced this pull request Jun 20, 2022
@facebook-github-bot
[JIT] Change SchemaCheckTensor into SchemaCheckMode and fix global va…
38559ce 
…riable issues (#79473)

Summary:
Pull Request resolved: #79473

Approved by: https://github.com/eellison

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/42fd58eaa0098f5f21890483d35cfcbd3ebcfb34

Reviewed By: malfet

Differential Revision: D37208504

Pulled By: goldenxuett

fbshipit-source-id: ffaf9ef6929c53cfbc6a9c0905eab6010bb1c45c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

Assignees

No one assigned

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ttanpcs @facebook-github-bot @pytorchmergebot @eellison