Skip to content

Symbolic storage size #79492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Symbolic storage size #79492

wants to merge 2 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Jun 14, 2022 •
edited
Loading

@ezyang
Symbolic storage size
b8c63f6 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 14, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 69ca6f4 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Jun 14, 2022
Closed
Closed
albanD
albanD approved these changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@ezyang
Update on "Symbolic storage size"
69ca6f4 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Jun 14, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 16, 2022
@ezyang @facebook-github-bot
Symbolic storage size (#79492)
1d3b2d7 
Summary:
Signed-off-by: Edward Z. Yang <ezyangfb.com>

Pull Request resolved: #79492

Approved by: https://github.com/albanD

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/95f9ca4931529070333d82527920c81539fa0e0b

Reviewed By: malfet

Differential Revision: D37156688

Pulled By: ezyang

fbshipit-source-id: 85e2506b15484772f350a3432727f9a05b9df80c
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1219/head branch June 18, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @facebook-github-bot @pytorchmergebot @albanD