Skip to content

Conversation

@swang392
Copy link
Contributor

@swang392 swang392 commented Jun 14, 2022

Relates to #76700

Overview: Wrote GHA to get the latest commit SHA. Another component of the script is pushing this SHA to the viable/strict branch, which I will test on pytorch/pytorch-canary.

Todo in the next PR: add comment explaining cron, replace package installation statements with txt file

Test Plan: Monitor github actions results to see if the SHA printed is correct by running GHA on pytorch/pytorch-canary. The successful test workflow is here.

@swang392 swang392 requested a review from a team as a code owner June 14, 2022 20:49
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 14, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit dfe9342 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not urgent to address in this PR, but good to have a comment explaining the cron

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seemethere is this a good runner for these? I think these are okay, but maybe one of the premium runners?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this doesn't run very often I think these should be fine to use

@kit1980
Copy link
Contributor

kit1980 commented Jun 14, 2022

Please rebase on master to prevent asan (and maybe some other) test failures.

@swang392
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased viable-gha onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout viable-gha && git pull --rebase)

@swang392
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @swang392.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 20, 2022
…ster (#79559) (#79559)

Summary:
Relates to #76700

**Overview**: Wrote GHA to get the latest commit SHA. Another component of the script is pushing this SHA to the viable/strict branch, which I will test on pytorch/pytorch-canary.

Todo in the next PR: add comment explaining cron, replace package installation statements with txt file

**Test Plan:** Monitor github actions results to see if the SHA printed is correct by running GHA on pytorch/pytorch-canary. The successful test workflow is [here](https://github.com/pytorch/pytorch-canary/runs/6888486129?check_suite_focus=true).

Pull Request resolved: #79559
Approved by: https://github.com/janeyx99

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/69971dd111133ba67354ac2af9c67f20f262ec42

Reviewed By: malfet

Differential Revision: D37208294

Pulled By: swang392

fbshipit-source-id: 3a2a4face2fc02e7027f65f8c47987dc0daeae5e
@github-actions github-actions bot deleted the viable-gha branch February 17, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants