Skip to content

reinstate size and shape returning symints #79560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

reinstate size and shape returning symints #79560

wants to merge 6 commits into from

Conversation

Krovatkin
Copy link
Contributor

@Krovatkin Krovatkin commented Jun 14, 2022 •
edited
Loading

This PR redirects size and .shape to call sym_sizes

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 14, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 1549373 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@Krovatkin Krovatkin force-pushed the krovatkin/symint_size branch 2 times, most recently from 0636249 to 5d6d6a3 Compare June 16, 2022 05:50
@Chillee Chillee mentioned this pull request Jun 21, 2022
Closed
@Krovatkin Krovatkin force-pushed the krovatkin/symint_size branch from 5d6d6a3 to 4735476 Compare June 21, 2022 16:49
@Krovatkin Krovatkin requested a review from Chillee June 21, 2022 16:50
Chillee
Chillee approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped

@Chillee Chillee mentioned this pull request Jun 22, 2022
Closed
@Krovatkin Krovatkin force-pushed the krovatkin/symint_size branch 3 times, most recently from 9550073 to 9d2928b Compare July 6, 2022 19:55
@Krovatkin Krovatkin force-pushed the krovatkin/symint_size branch from 9d2928b to ae1dc24 Compare July 6, 2022 22:04
@Krovatkin Krovatkin force-pushed the krovatkin/symint_size branch from a7c28b3 to 1549373 Compare July 7, 2022 20:39
@Krovatkin
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Hey @Krovatkin.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 8, 2022
@Krovatkin @facebook-github-bot
reinstate size and shape returning symints (#79560) (#79560)
7eb97e4 
Summary:
This PR redirects `size` and `.shape` to call `sym_sizes`

Pull Request resolved: #79560
Approved by: https://github.com/Chillee

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8389ccbcd809e2596bd4f8a20d069fc919beefdf

Reviewed By: mehtanirav

Differential Revision: D37717200

Pulled By: Krovatkin

fbshipit-source-id: a462912b3eb71abbb6925097e564a95c0abd2ed6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chillee Chillee Chillee approved these changes

@albanD albanD Awaiting requested review from albanD

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Krovatkin @facebook-github-bot @pytorchmergebot @Chillee