Skip to content

[ci] don't upload sccache artifacts with the wrong extension #79663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ci] don't upload sccache artifacts with the wrong extension #79663

wants to merge 1 commit into from

Conversation

@suo
Copy link
Member

@suo suo commented Jun 16, 2022 •
edited
Loading

@suo suo requested a review from a team as a code owner June 16, 2022 00:46
suo added a commit that referenced this pull request Jun 16, 2022
@suo
[ci] don't upload sccache artifacts with the wrong extension
b3bd555 
ghstack-source-id: eb7e4fb
Pull Request resolved: #79663
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 16, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 9a59e63 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@suo
Copy link
Member Author

suo commented Jun 16, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @suo.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/suo/571/head branch June 19, 2022 14:16
facebook-github-bot pushed a commit that referenced this pull request Jun 20, 2022
@suo @facebook-github-bot
[ci] don't upload sccache artifacts with the wrong extension (#79663)
811e47d 
Summary:
Pull Request resolved: #79663

Approved by: https://github.com/zengk95

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/ac0d540db248400d13d116006ab10849bfdde61b

Reviewed By: malfet

Differential Revision: D37242147

Pulled By: suo

fbshipit-source-id: 4417cc1cd46946e06ae040ba4ccab975b3d91375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zengk95 zengk95 zengk95 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suo @facebook-github-bot @pytorchmergebot @zengk95