Fix view issue in embedding_dense_backward decomp #79857
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 95531bf (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
jansel
changed the title
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
Summary:
I was hitting:
```
File "/home/jansel/pytorch/torch/fx/experimental/proxy_tensor.py", line 66, in proxy_call
return CURRENT_DECOMPOSITION_TABLE[func_overload](*args, **kwargs)
File "/home/jansel/pytorch/torch/_decomp/decompositions.py", line 801, in embedding_dense_backward
indices_rank1 = indices.view(numel)
File "/home/jansel/pytorch/torch/fx/experimental/proxy_tensor.py", line 122, in __torch_dispatch__
return proxy_call(func_overload, args, kwargs)
File "/home/jansel/pytorch/torch/fx/experimental/proxy_tensor.py", line 86, in proxy_call
real_out = func_overload(*args, **kwargs)
File "/home/jansel/pytorch/torch/_ops.py", line 49, in __call__
return self._op(*args, **kwargs or {})
RuntimeError: view size is not compatible with input tensor's size and stride (at least one dimension spans across two contiguous subspaces). Use .reshape(...) instead.
```
Pull Request resolved: #79857
Approved by: https://github.com/Chillee
Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d2e18606e7a98fa1c8e056381f2835c77ed2f60e
Reviewed By: atalman
Differential Revision: D37311418
Pulled By: jansel
fbshipit-source-id: ed40256b79f092fd1ae5c6f2cfb83193adf5426e
miladm
pushed a commit
to miladm/pytorch
that referenced
this pull request
Jun 27, 2022
I was hitting:
```
File "/home/jansel/pytorch/torch/fx/experimental/proxy_tensor.py", line 66, in proxy_call
return CURRENT_DECOMPOSITION_TABLE[func_overload](*args, **kwargs)
File "/home/jansel/pytorch/torch/_decomp/decompositions.py", line 801, in embedding_dense_backward
indices_rank1 = indices.view(numel)
File "/home/jansel/pytorch/torch/fx/experimental/proxy_tensor.py", line 122, in __torch_dispatch__
return proxy_call(func_overload, args, kwargs)
File "/home/jansel/pytorch/torch/fx/experimental/proxy_tensor.py", line 86, in proxy_call
real_out = func_overload(*args, **kwargs)
File "/home/jansel/pytorch/torch/_ops.py", line 49, in __call__
return self._op(*args, **kwargs or {})
RuntimeError: view size is not compatible with input tensor's size and stride (at least one dimension spans across two contiguous subspaces). Use .reshape(...) instead.
```
Pull Request resolved: pytorch#79857
Approved by: https://github.com/Chillee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hitting: