Revert "Revert "Add support for directly passing symint to empty"" #79954

Krovatkin · 2022-06-21T18:19:58Z

Relanding https://github.com/Krovatkin/pytorch/pull/new/krovatkin/symint_empty

facebook-github-bot · 2022-06-21T18:20:06Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/79954
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit ba800c6 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Chillee

stamp

ezyang · 2022-06-27T15:31:59Z

I'm taking a look at why this is failing

kulinseth

Looks good.

ezyang · 2022-06-29T15:38:01Z

will fix the lint later, just running to get more signal

Krovatkin · 2022-06-29T19:34:45Z

@pytorchbot merge -g

pytorchmergebot · 2022-06-29T19:36:07Z

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot · 2022-06-29T21:21:32Z

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2585422153

ezyang · 2022-06-29T21:44:20Z

@pytorchbot rebase

pytorchmergebot · 2022-06-29T21:45:44Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-06-29T21:45:48Z

Successfully rebased krovatkin/symint_empty onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout krovatkin/symint_empty && git pull --rebase)

ezyang · 2022-06-30T03:59:56Z

nooo land race

ezyang · 2022-06-30T15:59:44Z

@pytorchbot rebase

pytorchmergebot · 2022-06-30T16:01:24Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-06-30T16:01:28Z

Successfully rebased krovatkin/symint_empty onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout krovatkin/symint_empty && git pull --rebase)

ezyang · 2022-06-30T16:02:12Z

@pytorchbot merge -g

pytorchmergebot · 2022-06-30T16:03:33Z

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot · 2022-06-30T16:48:44Z

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2591219806

ezyang · 2022-07-04T16:34:58Z

@pytorchbot rebase

pytorchmergebot · 2022-07-04T16:36:30Z

@pytorchbot successfully started a rebase job. Check the current status here

This reverts commit aa9d25e.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

pytorchmergebot · 2022-07-04T16:36:35Z

Successfully rebased krovatkin/symint_empty onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout krovatkin/symint_empty && git pull --rebase)

ezyang · 2022-07-04T16:57:06Z

@pytorchbot merge -g

pytorchmergebot · 2022-07-04T16:58:15Z

@pytorchbot successfully started a merge job. Check the current status here

github-actions · 2022-07-04T20:09:40Z

Hey @Krovatkin.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

…79954) (#79954) Summary: Relanding https://github.com/Krovatkin/pytorch/pull/new/krovatkin/symint_empty Pull Request resolved: #79954 Approved by: https://github.com/Chillee, https://github.com/kulinseth Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/0a5123a75265a0a62b38873aad66b13144e8a2d8 Reviewed By: mehtanirav Differential Revision: D37618974 Pulled By: Krovatkin fbshipit-source-id: acb4f0977c91a02ceb67e2fa1b7b1a6cd07a3010

Krovatkin requested a review from bdhirsh as a code owner June 21, 2022 18:19

facebook-github-bot added the cla signed label Jun 21, 2022

Krovatkin requested a review from Chillee June 21, 2022 18:20

Chillee approved these changes Jun 21, 2022

View reviewed changes

Chillee mentioned this pull request Jun 22, 2022

Dynamic shape poc 2 #80001

Closed

Krovatkin force-pushed the krovatkin/symint_empty branch from 4a46565 to e380b3a Compare June 22, 2022 03:27

Krovatkin requested a review from kulinseth as a code owner June 28, 2022 18:20

kulinseth approved these changes Jun 29, 2022

View reviewed changes

pytorchmergebot force-pushed the krovatkin/symint_empty branch from 665d436 to e7d7ded Compare June 29, 2022 21:45

Krovatkin force-pushed the krovatkin/symint_empty branch from e7d7ded to 4bf7b5f Compare June 30, 2022 00:01

pytorchmergebot force-pushed the krovatkin/symint_empty branch from 716c051 to 7ffc354 Compare June 30, 2022 16:01

Revert "Revert "Add support for directly passing symint to empty""

90fdd57

This reverts commit aa9d25e.

Krovatkin and others added 12 commits July 4, 2022 16:36

redirect empty_symint back to empty

5180b5c

redirect all-int case to empty_meta in empty_meta_symint

9e0261b

format clang

d6983a5

wire empty_symint_device to empty_device directly

c83c674

remove dead code

5a81a1a

fix bug in symint conversion

00d9c57

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

add empty.symint override to LTC

8aefb9c

add empty.SymInt overloads to ORT

c605f86

update expect tests

8268844

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

remove symint from meta test

5215f20

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

fix lints

e843064

Default to the default impl instead of throwing an error

ba800c6

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

pytorchmergebot force-pushed the krovatkin/symint_empty branch from 7ffc354 to ba800c6 Compare July 4, 2022 16:36

pytorchmergebot added the Merged label Jul 4, 2022

pytorchmergebot closed this in 0a5123a Jul 4, 2022

Revert "Revert "Add support for directly passing symint to empty"" #79954

Revert "Revert "Add support for directly passing symint to empty"" #79954

Uh oh!

Conversation

Krovatkin commented Jun 21, 2022

Uh oh!

facebook-github-bot commented Jun 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

Chillee left a comment

Choose a reason for hiding this comment

Uh oh!

ezyang commented Jun 27, 2022

Uh oh!

kulinseth left a comment

Choose a reason for hiding this comment

Uh oh!

ezyang commented Jun 29, 2022

Uh oh!

Krovatkin commented Jun 29, 2022

Uh oh!

pytorchmergebot commented Jun 29, 2022

Uh oh!

pytorchmergebot commented Jun 29, 2022

Uh oh!

ezyang commented Jun 29, 2022

Uh oh!

pytorchmergebot commented Jun 29, 2022

Uh oh!

pytorchmergebot commented Jun 29, 2022

Uh oh!

ezyang commented Jun 30, 2022

Uh oh!

ezyang commented Jun 30, 2022

Uh oh!

pytorchmergebot commented Jun 30, 2022

Uh oh!

pytorchmergebot commented Jun 30, 2022

Uh oh!

ezyang commented Jun 30, 2022

Uh oh!

pytorchmergebot commented Jun 30, 2022

Uh oh!

pytorchmergebot commented Jun 30, 2022

Uh oh!

ezyang commented Jul 4, 2022

Uh oh!

pytorchmergebot commented Jul 4, 2022

Uh oh!

pytorchmergebot commented Jul 4, 2022

Uh oh!

ezyang commented Jul 4, 2022

Uh oh!

pytorchmergebot commented Jul 4, 2022

Uh oh!

github-actions bot commented Jul 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

facebook-github-bot commented Jun 21, 2022 •

edited

Loading