Skip to content

Switched to tracing overloads by default #80013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 1 commit into from
Closed

Switched to tracing overloads by default #80013

wants to merge 1 commit into from

Conversation

@Chillee
Copy link
Collaborator

@Chillee Chillee commented Jun 22, 2022

There are many cases where it's more convenient to use overloads, but we've hesitated in doing so since we can't torchscript it directly.

Luckily, it's pretty easy to strip overloads. See pytorch/functorch#899

@Chillee Chillee requested a review from zou3519 June 22, 2022 05:57
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 22, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 81a538f (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@Chillee
Copy link
Collaborator Author

Chillee commented Jun 22, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

@Chillee your PR has been successfully merged.

@github-actions
Copy link
Contributor

Hey @Chillee.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 23, 2022
@Chillee @facebook-github-bot
Switched to tracing overloads by default (#80013) (#80013)
8aed24b 
Summary:
There are many cases where it's more convenient to use overloads, but we've hesitated in doing so since we can't torchscript it directly.

Luckily, it's pretty easy to strip overloads. See pytorch/functorch#899

Pull Request resolved: #80013
Approved by: https://github.com/zou3519

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/159d459c50704771eb1c47e41c90d21632470595

Reviewed By: atalman

Differential Revision: D37357430

Pulled By: Chillee

fbshipit-source-id: fa3bfc5bdd25d0efc1972657110c9524f769fa01
@eellison eellison mentioned this pull request Jun 24, 2022
Merged
@github-actions github-actions bot deleted the trace_overloads branch February 17, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: fx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Chillee @facebook-github-bot @pytorchmergebot @zou3519