Skip to content

fix up trymerge #80100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix up trymerge #80100

wants to merge 1 commit into from

Conversation

@zengk95
Copy link
Contributor

@zengk95 zengk95 commented Jun 22, 2022 •
edited
Loading

Addresses #80096

In the Github API, they don't set the parent conclusion to FAILURE if one of the jobs has a failure. It's stuck at null until all jobs finish, which isn't good for TTS on mergebot.

Example GH response:
image
image

In here, we check if there's a failing check within the checkruns and if it is, it'll set the workflow run conclusion to failure

Test Plan:

Run the find_matching_merge_rule method and check that it throws a RunTimeError for pull on a certain PR

image

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 22, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit b327bb0 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@zengk95 zengk95 marked this pull request as ready for review June 22, 2022 23:19
@zengk95 zengk95 requested a review from a team as a code owner June 22, 2022 23:19
janeyx99
janeyx99 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me.

@zengk95
Copy link
Contributor Author

zengk95 commented Jun 23, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 23, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2022

Hey @zengk95.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 23, 2022
@zengk95 @facebook-github-bot
fix up trymerge (#80100) (#80100)
1795ddf 
Summary:
Addresses #80096

In the Github API, they don't set the parent conclusion to FAILURE if one of the jobs has a failure. It's stuck at null until all jobs finish, which isn't good for TTS on mergebot.

Example GH response:
<img width="827" alt="image" src="https://user-images.githubusercontent.com/34172846/175170084-de6bb419-925e-41a6-8c12-6732b35b6cab.png">
<img width="1264" alt="image" src="https://user-images.githubusercontent.com/34172846/175170180-c629ed4d-a174-4179-8321-1a192d1ec8f3.png">

In here, we check if there's a failing check within the checkruns and if it is, it'll set the workflow run conclusion to failure

Pull Request resolved: #80100
Approved by: https://github.com/janeyx99, https://github.com/seemethere

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/0a06bf89dba68b738c0454b6f54556caf449ad6d

Test plan from GitHub:
Run the find_matching_merge_rule method and check that it throws a RunTimeError for pull on a certain PR

<img width="1172" alt="image" src="https://user-images.githubusercontent.com/34172846/175170413-a28352c6-f518-4aa2-a068-d13df9f76268.png">

Reviewed By: atalman

Differential Revision: D37387175

Pulled By: zengk95

fbshipit-source-id: 2dfc626ba7b36e710bda5af4ff61d834688d377e
@janeyx99 janeyx99 mentioned this pull request Jun 27, 2022
Closed
@malfet
Copy link
Contributor

malfet commented Jun 28, 2022

Thank you for the fix, but please provide more details in PR title and avoid pictures when possible

@zengk95 zengk95 deleted the make-check-fail branch July 5, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zengk95 @facebook-github-bot @pytorchmergebot @malfet @seemethere @janeyx99