Skip to content

Conversation

@janeyx99
Copy link
Contributor

let's pin XLA
but not when the job's not run
thus this pull request

@janeyx99 janeyx99 requested a review from a team as a code owner June 24, 2022 17:56
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 24, 2022

🔗 Helpful links

❌ 2 New Failures

As of commit 62ae880 (more details on the Dr. CI page):

Expand to see more
  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-xenial-py3-clang5-mobile-build / build (1/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-06-24T18:01:06.3626858Z ##[error]Process completed with exit code 1.
2022-06-24T18:01:06.3591206Z Non-cacheable compilations            0
2022-06-24T18:01:06.3591446Z Non-cacheable calls                   0
2022-06-24T18:01:06.3591806Z Non-compilation calls                 0
2022-06-24T18:01:06.3592057Z Unsupported compiler calls            0
2022-06-24T18:01:06.3592261Z Average cache write               0.000 s
2022-06-24T18:01:06.3592533Z Average cache read miss           0.000 s
2022-06-24T18:01:06.3592759Z Average cache read hit            0.000 s
2022-06-24T18:01:06.3592978Z Failed distributed compilations       0
2022-06-24T18:01:06.3593721Z Cache location                  S3, bucket: Bucket(name=ossci-compiler-cache-circleci-v2, base_url=http://ossci-compiler-cache-circleci-v2.s3.amazonaws.com/)
2022-06-24T18:01:06.3594206Z /var/lib/jenkins/workspace/.jenkins/pytorch/common.sh: line 59: JOB_BASE_NAME: unbound variable
2022-06-24T18:01:06.3626858Z ##[error]Process completed with exit code 1.
2022-06-24T18:01:06.3656773Z Prepare all required actions
2022-06-24T18:01:06.3677706Z ##[group]Run ./.github/actions/teardown-linux
2022-06-24T18:01:06.3677918Z with:
2022-06-24T18:01:06.3678065Z ##[endgroup]
2022-06-24T18:01:06.3695127Z ##[group]Run .github/scripts/wait_for_ssh_to_drain.sh
2022-06-24T18:01:06.3695396Z �[36;1m.github/scripts/wait_for_ssh_to_drain.sh�[0m
2022-06-24T18:01:06.3707183Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-06-24T18:01:06.3707403Z ##[endgroup]
2022-06-24T18:01:06.3746636Z Holding runner for 2 hours until all ssh sessions have logged out
2022-06-24T18:01:06.3786743Z ##[group]Run # ignore expansion of "docker ps -q" since it could be empty

See GitHub Actions build pull / linux-xenial-py3-clang5-mobile-custom-build-static / build (2/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-06-24T18:01:39.6330671Z ##[error]Process completed with exit code 1.
2022-06-24T18:01:39.6296007Z Non-cacheable compilations            0
2022-06-24T18:01:39.6296265Z Non-cacheable calls                   0
2022-06-24T18:01:39.6296496Z Non-compilation calls                 0
2022-06-24T18:01:39.6296718Z Unsupported compiler calls            0
2022-06-24T18:01:39.6296987Z Average cache write               0.000 s
2022-06-24T18:01:39.6297187Z Average cache read miss           0.000 s
2022-06-24T18:01:39.6297400Z Average cache read hit            0.000 s
2022-06-24T18:01:39.6299412Z Failed distributed compilations       0
2022-06-24T18:01:39.6300388Z Cache location                  S3, bucket: Bucket(name=ossci-compiler-cache-circleci-v2, base_url=http://ossci-compiler-cache-circleci-v2.s3.amazonaws.com/)
2022-06-24T18:01:39.6301047Z /var/lib/jenkins/workspace/.jenkins/pytorch/common.sh: line 59: JOB_BASE_NAME: unbound variable
2022-06-24T18:01:39.6330671Z ##[error]Process completed with exit code 1.
2022-06-24T18:01:39.6361457Z Prepare all required actions
2022-06-24T18:01:39.6381012Z ##[group]Run ./.github/actions/teardown-linux
2022-06-24T18:01:39.6381216Z with:
2022-06-24T18:01:39.6381362Z ##[endgroup]
2022-06-24T18:01:39.6396262Z ##[group]Run .github/scripts/wait_for_ssh_to_drain.sh
2022-06-24T18:01:39.6396521Z �[36;1m.github/scripts/wait_for_ssh_to_drain.sh�[0m
2022-06-24T18:01:39.6413599Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-06-24T18:01:39.6413829Z ##[endgroup]
2022-06-24T18:01:39.6452528Z Holding runner for 2 hours until all ssh sessions have logged out
2022-06-24T18:01:39.6491079Z ##[group]Run # ignore expansion of "docker ps -q" since it could be empty

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@suo
Copy link
Member

suo commented Jun 24, 2022

excellent PR
I agree that this is good
acceptance from me

@janeyx99
Copy link
Contributor Author

@pytorchbot merge -f

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @janeyx99.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 27, 2022
Summary:
let's pin XLA
but not when the job's not run
thus this pull request

Pull Request resolved: #80233
Approved by: https://github.com/suo

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/9dd16c18854a050fd4cf96882ee50565fa18a2d7

Reviewed By: atalman

Differential Revision: D37455616

Pulled By: janeyx99

fbshipit-source-id: 5f5d2b2af42442207d3f1f34a7d4eed9f18d27c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants