Skip to content

Ensure torch._refs registrations also get triggered on import torch #80270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Ensure torch._refs registrations also get triggered on import torch #80270

wants to merge 1 commit into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Jun 25, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Fixes #79938

Signed-off-by: Edward Z. Yang ezyang@fb.com

@ezyang
Ensure torch._refs registrations also get triggered on import torch
ec09777 
Fixes #79938

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 25, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit ec09777 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

ezyang added a commit that referenced this pull request Jun 25, 2022
@ezyang
Ensure torch._refs registrations also get triggered on import torch
8c838b3 
Fixes #79938

Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: 8ea2d3f
Pull Request resolved: #80270
@ezyang ezyang requested review from mruberry and ngimel June 25, 2022 03:42
@ezyang
Copy link
Contributor Author

ezyang commented Jun 25, 2022

cc @xiurobert

@bushshrub
Copy link
Contributor

bushshrub commented Jun 25, 2022 •
edited
Loading

cc @xiurobert

I will rebase on this PR, looks like it is working.

@ezyang
Copy link
Contributor Author

ezyang commented Jun 26, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1223/head branch June 29, 2022 14:17
facebook-github-bot pushed a commit that referenced this pull request Jun 29, 2022
@ezyang @facebook-github-bot
Ensure torch._refs registrations also get triggered on import torch (#…
0333811 
…80270) (#80270)

Summary:
Fixes #79938

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Pull Request resolved: #80270
Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/4331bc436ea5ad56f22041312250c08a3ce3e5d2

Reviewed By: atalman

Differential Revision: D37455797

Pulled By: ezyang

fbshipit-source-id: 23469eb93b0b05e3b8e2b3a2d11adb0c68174918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

@mruberry mruberry Awaiting requested review from mruberry

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ezyang @facebook-github-bot @bushshrub @pytorchmergebot @ngimel