Skip to content

Copy Tensor for tests to avoid in-place transform modifying the original tensor #80331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Copy Tensor for tests to avoid in-place transform modifying the original tensor #80331

wants to merge 2 commits into from

Conversation

@Flamefire
Copy link
Collaborator

Fixes #48591

CC @mruberry after #60256

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 27, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (1 Pending)

As of commit d3e5b68 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@mruberry mruberry self-requested a review June 27, 2022 13:21
@mruberry mruberry added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 27, 2022
mruberry
mruberry approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Flamefire!

@mruberry
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @Flamefire.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@Flamefire Flamefire deleted the nan_in_test_torch branch June 28, 2022 07:01
facebook-github-bot pushed a commit that referenced this pull request Jun 30, 2022
@Flamefire @facebook-github-bot
Copy Tensor for tests to avoid in-place transform modifying the origi…
fd936ac 
…nal tensor (#80331) (#80331)

Summary:
Fixes #48591

CC mruberry  after #60256

Pull Request resolved: #80331
Approved by: https://github.com/mruberry

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/3b8589ac4470095ac4dd623f709a12bd47526188

Reviewed By: b0noI

Differential Revision: D37495867

fbshipit-source-id: 72179e706b6b98da3dbf70e523794ca4886c26cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test failure in test_memory_format_operators and faulty test

5 participants

@Flamefire @facebook-github-bot @mruberry @pytorchmergebot @pytorchbot