Skip to content

Wrap static initializers in ifdef #80590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Wrap static initializers in ifdef #80590

wants to merge 1 commit into from

Conversation

qihqi
Copy link
Contributor

@qihqi qihqi commented Jun 30, 2022

because, on iOS some projects has -Wglobal-constructors and it won't build.

Fixes #ISSUE_NUMBER

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 30, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 7a1671c (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

@qihqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@qihqi qihqi requested a review from cccclai June 30, 2022 04:35
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 30, 2022
@facebook-github-bot
Copy link
Contributor

@qihqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@qihqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Contributor

cccclai commented Jun 30, 2022

LGTM

cccclai
cccclai reviewed Jun 30, 2022
View reviewed changes
torch/csrc/jit/serialization/flatbuffer_serializer_jit.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some comments for it?

@qihqi
Copy link
Contributor Author

qihqi commented Jun 30, 2022 •
edited
Loading

@pytorchbot m

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Matched rule superuser, but PR #80590 has not been reviewed yet
Raised by https://github.com/pytorch/pytorch/actions/runs/2592507582

@facebook-github-bot
Copy link
Contributor

@qihqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@qihqi
Wrap static initializers in ifdef
7a1671c 
because, on iOS some projects has -Wglobal-constructors and it won't build.
@facebook-github-bot
Copy link
Contributor

@qihqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@qihqi
Copy link
Contributor Author

qihqi commented Jul 1, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

Hey @qihqi.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 5, 2022
@qihqi @facebook-github-bot
Wrap static initializers in ifdef (#80590) (#80590)
ed4e8c1 
Summary:
because, on iOS some projects has -Wglobal-constructors and it won't build.

Fixes #ISSUE_NUMBER

Pull Request resolved: #80590
Approved by: https://github.com/cccclai

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/c93ceef6585e140c1a33744374f76b2341bfe465

Reviewed By: cccclai

Differential Revision: D37544177

Pulled By: qihqi

fbshipit-source-id: e6624c50e3ee00af4176681bb2c2d48a0205c731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccclai cccclai cccclai approved these changes

Assignees

No one assigned

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qihqi @facebook-github-bot @cccclai @pytorchmergebot