Skip to content

Conversation

@vspenubarthi
Copy link
Contributor

@vspenubarthi vspenubarthi commented Jun 30, 2022

Stack from ghstack (oldest at bottom):

Summary: This adds the class framework for the ModelReport
OutlierDetector. This detector will be in charge of looking at
activation data and figuring out whether there are significant oultiers
present in them. It will average this data across batches to make a
recommendation / warning if significant outliers are found.

This commit contains just the class framework and a base test class.
Implementations will follow in following commits.

Test Plan: python test/test_quantization.py TestFxDetectOutliers

Reviewers:

Subscribers:

Tasks:

Tags:

Summary: This adds the class framework for the ModelReport
OutlierDetector. This detector will be in charge of looking at
activation data and figuring out whether there are significant oultiers
present in them. It will average this data across batches to make a
recommendation / warning if significant outliers are found.

This commit contains just the class framework and a base test class.
Implementations will follow in following commits.

Test Plan: python test/test_quantization.py TestFxDetectOutliers

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
vspenubarthi added a commit that referenced this pull request Jun 30, 2022
Summary: This adds the class framework for the ModelReport
OutlierDetector. This detector will be in charge of looking at
activation data and figuring out whether there are significant oultiers
present in them. It will average this data across batches to make a
recommendation / warning if significant outliers are found.

This commit contains just the class framework and a base test class.
Implementations will follow in following commits.

Test Plan: python test/test_quantization.py TestFxDetectOutliers

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ba42965
Pull Request resolved: #80743
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 30, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 58b667c (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor

@HDCharles HDCharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vspenubarthi vspenubarthi added topic: new features topic category release notes: quantization release notes category labels Jul 1, 2022
@vspenubarthi
Copy link
Contributor Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@facebook-github-bot facebook-github-bot deleted the gh/vspenubarthi/18/head branch July 4, 2022 14:18
facebook-github-bot pushed a commit that referenced this pull request Jul 5, 2022
Summary:
This adds the class framework for the ModelReport
OutlierDetector. This detector will be in charge of looking at
activation data and figuring out whether there are significant oultiers
present in them. It will average this data across batches to make a
recommendation / warning if significant outliers are found.

This commit contains just the class framework and a base test class.
Implementations will follow in following commits.

Pull Request resolved: #80743
Approved by: https://github.com/HDCharles

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e5162dcfa723c50a09da3bba2ee98f6c1e73fd83

Test plan from GitHub:
python test/test_quantization.py TestFxDetectOutliers

Reviewed By: b0noI

Differential Revision: D37578942

Pulled By: vspenubarthi

fbshipit-source-id: a027a2faf3ffc2a3729d4076f432395cc11be3ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants