-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[ao] Added framework for ModelReport Outlier Detector #80743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This adds the class framework for the ModelReport OutlierDetector. This detector will be in charge of looking at activation data and figuring out whether there are significant oultiers present in them. It will average this data across batches to make a recommendation / warning if significant outliers are found. This commit contains just the class framework and a base test class. Implementations will follow in following commits. Test Plan: python test/test_quantization.py TestFxDetectOutliers Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vspenubarthi
added a commit
that referenced
this pull request
Jun 30, 2022
Summary: This adds the class framework for the ModelReport OutlierDetector. This detector will be in charge of looking at activation data and figuring out whether there are significant oultiers present in them. It will average this data across batches to make a recommendation / warning if significant outliers are found. This commit contains just the class framework and a base test class. Implementations will follow in following commits. Test Plan: python test/test_quantization.py TestFxDetectOutliers Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ba42965 Pull Request resolved: #80743
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 58b667c (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
HDCharles
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@pytorchbot merge -g |
|
@pytorchbot successfully started a merge job. Check the current status here |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 5, 2022
Summary: This adds the class framework for the ModelReport OutlierDetector. This detector will be in charge of looking at activation data and figuring out whether there are significant oultiers present in them. It will average this data across batches to make a recommendation / warning if significant outliers are found. This commit contains just the class framework and a base test class. Implementations will follow in following commits. Pull Request resolved: #80743 Approved by: https://github.com/HDCharles Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e5162dcfa723c50a09da3bba2ee98f6c1e73fd83 Test plan from GitHub: python test/test_quantization.py TestFxDetectOutliers Reviewed By: b0noI Differential Revision: D37578942 Pulled By: vspenubarthi fbshipit-source-id: a027a2faf3ffc2a3729d4076f432395cc11be3ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla signed
Merged
module: fx
release notes: quantization
release notes category
topic: new features
topic category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: This adds the class framework for the ModelReport
OutlierDetector. This detector will be in charge of looking at
activation data and figuring out whether there are significant oultiers
present in them. It will average this data across batches to make a
recommendation / warning if significant outliers are found.
This commit contains just the class framework and a base test class.
Implementations will follow in following commits.
Test Plan: python test/test_quantization.py TestFxDetectOutliers
Reviewers:
Subscribers:
Tasks:
Tags: