Skip to content

Improve readability of cuda_lazy_init #80788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve readability of cuda_lazy_init #80788

wants to merge 1 commit into from

Conversation

cbalioglu
Copy link
Contributor

This PR cleans up the implementation of cuda_lazy_init.cpp and improves its readability. No behavioral changes are introduced.

@cbalioglu cbalioglu requested review from bdhirsh and ezyang July 1, 2022 23:00
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 1, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 6b04de2 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@ezyang
Copy link
Contributor

ezyang commented Jul 4, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

Hey @cbalioglu.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@cbalioglu cbalioglu added release notes: cuda release notes category topic: not user facing topic category labels Jul 5, 2022
@cbalioglu cbalioglu deleted the cuda_init branch July 5, 2022 13:09
facebook-github-bot pushed a commit that referenced this pull request Jul 6, 2022
@cbalioglu @facebook-github-bot
Improve readability of cuda_lazy_init (#80788) (#80788)
b92c401 
Summary:
This PR cleans up the implementation of `cuda_lazy_init.cpp` and improves its readability. No behavioral changes are introduced.

Pull Request resolved: #80788
Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/081b56fd41de591669bd1f61d4aadd7eb65ec335

Reviewed By: mehtanirav

Differential Revision: D37604767

Pulled By: cbalioglu

fbshipit-source-id: 82b360c68559ed9820a7499e4fb2dff87cd4ec1d
@cbalioglu cbalioglu mentioned this pull request Jul 10, 2022
Closed
pytorchmergebot pushed a commit that referenced this pull request Jul 11, 2022
@cbalioglu @pytorchmergebot
Fix set_requires_cuda_init (#81183)
56dea92 
Fixes the buggy `set_requires_cuda_init` introduced in #80788.

Pull Request resolved: #81183
Approved by: https://github.com/ezyang
facebook-github-bot pushed a commit that referenced this pull request Jul 12, 2022
@cbalioglu @facebook-github-bot
Fix set_requires_cuda_init (#81183) (#81183)
4680f7b 
Summary:
Fixes the buggy `set_requires_cuda_init` introduced in #80788.

Pull Request resolved: #81183
Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/56dea92d973ff16b41cb812b69c5a7ab8c9d1109

Reviewed By: mehtanirav

Differential Revision: D37760038

Pulled By: cbalioglu

fbshipit-source-id: 934781cb9550806895683909d362b5ce856d826e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

Assignees

No one assigned

Labels

cla signed Merged release notes: cuda release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbalioglu @facebook-github-bot @ezyang @pytorchmergebot