Skip to content

Conversation

@macandro96
Copy link

@macandro96 macandro96 commented Jul 5, 2022

Stack from ghstack (oldest at bottom):

Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
python test/test_ao_sparsity.py TestActivationSparsifier

Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
```python test/test_ao_sparsity.py TestActivationSparsifier```

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 5, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit e96b3d3 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
```python test/test_ao_sparsity.py TestActivationSparsifier```

[ghstack-poisoned]
@macandro96 macandro96 requested review from HDCharles and z-a-f July 5, 2022 17:44
macandro96 added 8 commits July 11, 2022 17:51
Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
```python test/test_ao_sparsity.py TestActivationSparsifier```

[ghstack-poisoned]
Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
```python test/test_ao_sparsity.py TestActivationSparsifier```

[ghstack-poisoned]
Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
```python test/test_ao_sparsity.py TestActivationSparsifier```

[ghstack-poisoned]
Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
```python test/test_ao_sparsity.py TestActivationSparsifier```

[ghstack-poisoned]
Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
```python test/test_ao_sparsity.py TestActivationSparsifier```

[ghstack-poisoned]
Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
```python test/test_ao_sparsity.py TestActivationSparsifier```

[ghstack-poisoned]
Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
```python test/test_ao_sparsity.py TestActivationSparsifier```

[ghstack-poisoned]
Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
```python test/test_ao_sparsity.py TestActivationSparsifier```

[ghstack-poisoned]
@macandro96 macandro96 requested a review from z-a-f July 14, 2022 19:34
Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
```python test/test_ao_sparsity.py TestActivationSparsifier```

[ghstack-poisoned]
Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
```python test/test_ao_sparsity.py TestActivationSparsifier```

[ghstack-poisoned]
Copy link

@z-a-f z-a-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macandro96 Check the tests + dynamo. Once fixed, you can merge

Unregisters aggreagate hook that was applied earlier and registers sparsification hooks.
The sparsification hook will apply the mask to the activations before it is fed into the
attached layer.

Test Plan:
```python test/test_ao_sparsity.py TestActivationSparsifier```

[ghstack-poisoned]
@macandro96
Copy link
Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @macandro96.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/macandro96/19/head branch July 26, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants