[composite compliance testing] Refactor check_backward_formula to accept Callable #81059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ept Callable
Maybe niche, but for one-off debugging purposes, I want a variant of
check_backward_formula that accepts a callable rather than an OpInfo.
This is because when debugging, I try to create a repro that does not
involve OpInfos because OpInfos are difficult to deal with (they have
a lot of sample inputs, I may want to test my own sample inputs without
creating a new OpInfo, etc).
This PR refactors check_backward_formula so that it accepts a Callable
instead of an OpInfo. Example usage:
```
import torch
from torch.testing._internal.composite_compliance import check_backward_formula
x = torch.tensor([[1., 1.], [1., 0.]], requires_grad=True)
args = (x, 1)
check_backward_formula_callable(torch.prod, args, {})
```
Test Plan:
- run existing tests
[ghstack-poisoned]
This was referenced Jul 7, 2022
🔗 Helpful links
✅ No Failures (0 Pending)As of commit cfb812d (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
zou3519
requested review from
ezyang and
kshitij12345
and removed request for
mruberry and
ngimel
kshitij12345
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
This is would really be helpful. Thanks!
I think we should also do this for
pytorch/torch/testing/_internal/composite_compliance.py
Lines 446 to 449 in 8a5d984
ezyang
approved these changes
Jul 10, 2022
…mula to accept Callable"
Maybe niche, but for one-off debugging purposes, I want a variant of
check_backward_formula that accepts a callable rather than an OpInfo.
This is because when debugging, I try to create a repro that does not
involve OpInfos because OpInfos are difficult to deal with (they have
a lot of sample inputs, I may want to test my own sample inputs without
creating a new OpInfo, etc).
This PR refactors check_backward_formula so that it accepts a Callable
instead of an OpInfo. Example usage:
```
import torch
from torch.testing._internal.composite_compliance import check_backward_formula
x = torch.tensor([[1., 1.], [1., 0.]], requires_grad=True)
args = (x, 1)
check_backward_formula_callable(torch.prod, args, {})
```
Test Plan:
- run existing tests
[ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Jul 11, 2022
…ccept Callable Like #81059; this PR addresses the review comments. Test Plan: - run tests [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 11, 2022
…ccept Callable (#81239) Like #81059; this PR addresses the review comments. Test Plan: - run tests Pull Request resolved: #81239 Approved by: https://github.com/ezyang
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
…ept Callable (#81059) (#81059) Summary: Maybe niche, but for one-off debugging purposes, I want a variant of check_backward_formula that accepts a callable rather than an OpInfo. This is because when debugging, I try to create a repro that does not involve OpInfos because OpInfos are difficult to deal with (they have a lot of sample inputs, I may want to test my own sample inputs without creating a new OpInfo, etc). This PR refactors check_backward_formula so that it accepts a Callable instead of an OpInfo. Example usage: ``` import torch from torch.testing._internal.composite_compliance import check_backward_formula x = torch.tensor([[1., 1.], [1., 0.]], requires_grad=True) args = (x, 1) check_backward_formula_callable(torch.prod, args, {}) ``` Pull Request resolved: #81059 Approved by: https://github.com/kshitij12345, https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d253cdd8ff194239e86b70293793e814e44da2c0 Test plan from GitHub: - run existing tests Reviewed By: DanilBaibak Differential Revision: D37781921 Pulled By: zou3519 fbshipit-source-id: 44e128c7873ada4203753f144ef3780ca4de2e40
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
…ccept Callable (#81239) (#81239) Summary: Like #81059; this PR addresses the review comments. Pull Request resolved: #81239 Approved by: https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/9ee312023d8591b1afed19e145cdf61039753a40 Test plan from GitHub: - run tests Reviewed By: DanilBaibak Differential Revision: D37781963 Pulled By: zou3519 fbshipit-source-id: 938a737f44fa93f9b53ae20395c80cd3e89aa549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Maybe niche, but for one-off debugging purposes, I want a variant of
check_backward_formula that accepts a callable rather than an OpInfo.
This is because when debugging, I try to create a repro that does not
involve OpInfos because OpInfos are difficult to deal with (they have
a lot of sample inputs, I may want to test my own sample inputs without
creating a new OpInfo, etc).
This PR refactors check_backward_formula so that it accepts a Callable
instead of an OpInfo. Example usage:
Test Plan: