Skip to content

Conversation

@yeounoh
Copy link
Contributor

@yeounoh yeounoh commented Jul 7, 2022

@yeounoh yeounoh requested a review from a team as a code owner July 7, 2022 22:51
@yeounoh yeounoh self-assigned this Jul 7, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 7, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 1880288 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet
Copy link
Contributor

malfet commented Jul 8, 2022

@yeounoh why does PR have 230 commits in it?

@yeounoh
Copy link
Contributor Author

yeounoh commented Jul 8, 2022

@yeounoh why does PR have 230 commits in it?

Rebased the master -- let me reset (EDIT: we have a single commit now, @malfet )

By the way, is this a known issue?
.jenkins/pytorch/common_utils.sh: line 147: jq: command not found

@yeounoh yeounoh force-pushed the test_llvm_bazel_cache branch from fbdddbd to e9e6267 Compare July 8, 2022 00:40
@yeounoh yeounoh force-pushed the test_llvm_bazel_cache branch from e9c9b02 to 1880288 Compare July 8, 2022 03:10
@yeounoh
Copy link
Contributor Author

yeounoh commented Jul 8, 2022

Ok, the xla workflow is green again cc @malfet

@ezyang
Copy link
Contributor

ezyang commented Jul 8, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Hey @yeounoh.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 8, 2022
Summary:
Follow-up on #80178 (comment)

cc seemethere malfet

Pull Request resolved: #81070
Approved by: https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/7ced3921d7b3bb12fbdce11e4692c6357a73ce31

Reviewed By: mehtanirav

Differential Revision: D37717295

Pulled By: mehtanirav

fbshipit-source-id: ecf9303ae13a35571433f217d4be6fb3fdc8d291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants