-
Notifications
You must be signed in to change notification settings - Fork 25.7k
ci: Add docker image build to linux test step #81227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds a docker image build to the linux test step in the case where the docker image does not exist and the docker-builds step has not been run Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit ee9c8ae (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Adds a docker image build to the linux test step in the case where the docker image does not exist and the docker-builds step has not been run Signed-off-by: Eli Uriegas <eliuriegasfb.com> [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this feels slightly wrong, is there are reason why we need to pass both image name and image base?
It introduces unseeded repetition and possibility for typos in configs
| docker-image-name: | ||
| description: The docker image to use for the rest of the workflow | ||
| value: ${{ steps.calculate-tag.outputs.docker-image-name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, shouldn't it always be $(basename ${{ inpouts.docker_image_base }} )
In that case, may be it should be computed, rather than passed directly?
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Stack from ghstack:
Adds a docker image build to the linux test step in the case where the
docker image does not exist and the docker-builds step has not been run
Signed-off-by: Eli Uriegas eliuriegas@fb.com