Skip to content

Conversation

@seemethere
Copy link
Member

@seemethere seemethere commented Jul 11, 2022

Stack from ghstack:

Adds a docker image build to the linux test step in the case where the
docker image does not exist and the docker-builds step has not been run

Signed-off-by: Eli Uriegas eliuriegas@fb.com

Adds a docker image build to the linux test step in the case where the
docker image does not exist and the docker-builds step has not been run

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
@seemethere seemethere requested a review from a team as a code owner July 11, 2022 12:44
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 11, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit ee9c8ae (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Adds a docker image build to the linux test step in the case where the
docker image does not exist and the docker-builds step has not been run

Signed-off-by: Eli Uriegas <eliuriegasfb.com>

[ghstack-poisoned]
@seemethere seemethere added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 11, 2022
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this feels slightly wrong, is there are reason why we need to pass both image name and image base?
It introduces unseeded repetition and possibility for typos in configs

Comment on lines +35 to +37
docker-image-name:
description: The docker image to use for the rest of the workflow
value: ${{ steps.calculate-tag.outputs.docker-image-name }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, shouldn't it always be $(basename ${{ inpouts.docker_image_base }} )
In that case, may be it should be computed, rather than passed directly?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Sep 9, 2022
@seemethere seemethere closed this Sep 9, 2022
@facebook-github-bot facebook-github-bot deleted the gh/seemethere/251/head branch June 8, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants