[ao] Fix for extra lines after return in Outlier Detector #81499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: There were accidently two lines added after a return statement in the OutlierDetecor insertion that was not caught by either the linter nor the tests nor i, that were harmless, but some odd merge issue. This removes those two lines. Test Plan: python test/test_quantization.py TestFxDetectOutliers Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 371d736 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
vspenubarthi
added
release notes: quantization
kit1980
approved these changes
Jul 14, 2022
|
@pytorchbot merge -g |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser |
Summary: There were accidently two lines added after a return statement in the OutlierDetecor insertion that was not caught by either the linter nor the tests nor i, that were harmless, but some odd merge issue. This removes those two lines. Test Plan: python test/test_quantization.py TestFxDetectOutliers Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vspenubarthi
added a commit
that referenced
this pull request
Jul 14, 2022
Summary: There were accidently two lines added after a return statement in the OutlierDetecor insertion that was not caught by either the linter nor the tests nor i, that were harmless, but some odd merge issue. This removes those two lines. Test Plan: python test/test_quantization.py TestFxDetectOutliers Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 221ccbe Pull Request resolved: #81499
|
@pytorchbot merge -g |
|
@pytorchbot successfully started a merge job. Check the current status here |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 15, 2022
…81499) Summary: There were accidently two lines added after a return statement in the OutlierDetecor insertion that was not caught by either the linter nor the tests nor i, that were harmless, but some odd merge issue. This removes those two lines. Pull Request resolved: #81499 Approved by: https://github.com/kit1980 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/845792db3cab2c80aa6587fe7a1731cde918be8f Test plan from GitHub: python test/test_quantization.py TestFxDetectOutliers Reviewed By: DanilBaibak Differential Revision: D37876486 Pulled By: vspenubarthi fbshipit-source-id: d6e6a8651710963cd326922c480b878449effcef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: There were accidently two lines added after a return statement
in the OutlierDetecor insertion that was not caught by either the linter
nor the tests nor i, that were harmless, but some odd merge issue. This
removes those two lines.
Test Plan: python test/test_quantization.py TestFxDetectOutliers
Reviewers:
Subscribers:
Tasks:
Tags: