Skip to content

Correct super class name #81507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 1 commit into from
Closed

Correct super class name #81507

wants to merge 1 commit into from

Conversation

@kit1980
Copy link
Contributor

@kit1980 kit1980 commented Jul 14, 2022

No description provided.

@kit1980 kit1980 requested a review from emcastillo July 14, 2022 22:04
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 14, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 9b8878f (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@kit1980 kit1980 added the better-engineering Relatively self-contained tasks for better engineering contributors label Jul 15, 2022
@kit1980 kit1980 requested a review from a team July 17, 2022 01:28
@kit1980
Copy link
Contributor Author

kit1980 commented Jul 18, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @kit1980.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 19, 2022
@kit1980 @facebook-github-bot
Correct super class name (#81507) (#81507)
baf02c9 
Summary:
Pull Request resolved: #81507
Approved by: https://github.com/seemethere

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e3a569384a11fe04bb457e5bc35cd3305d5d54f8

Reviewed By: jeanschmidt

Differential Revision: D37951921

Pulled By: kit1980

fbshipit-source-id: cbd8ef600b24f606486289eac7fbc750ede6a279
@kit1980 kit1980 deleted the sdym/super-stream branch September 13, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@emcastillo emcastillo Awaiting requested review from emcastillo

Assignees

No one assigned

Labels

better-engineering Relatively self-contained tasks for better engineering contributors cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kit1980 @facebook-github-bot @pytorchmergebot @seemethere