Skip to content

Stop attempting to install networkx (it's already installed) #81555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Stop attempting to install networkx (it's already installed) #81555

wants to merge 1 commit into from

Conversation

@zou3519
Copy link
Contributor

@zou3519 zou3519 commented Jul 15, 2022 •
edited
Loading

@zou3519
Stop attempting to install networkx (it's already installed)
b92a54a 
Addresses review comment from
#81403 (comment)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 15, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit b92a54a (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

malfet
malfet approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@malfet
Copy link
Contributor

malfet commented Jul 15, 2022

@pytorchbot merge -f

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @zou3519.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@zou3519 zou3519 mentioned this pull request Jul 15, 2022
Closed
facebook-github-bot pushed a commit that referenced this pull request Jul 18, 2022
@zou3519 @facebook-github-bot
Stop attempting to install networkx (it's already installed) (#81555) (…
25715e4 
…#81555)

Summary:
Addresses review comment from
#81403 (comment)

Pull Request resolved: #81555
Approved by: https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/6b82601bbc0aad8da568b57b4d9f1043017e54b7

Reviewed By: DanilBaibak

Differential Revision: D37919420

Pulled By: zou3519

fbshipit-source-id: 8ca2367c59aabe47575dbaaff1155f44b59062bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zou3519 @facebook-github-bot @malfet @pytorchmergebot