Skip to content

[PTE] Fix module level information in profiling #81727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[PTE] Fix module level information in profiling #81727

wants to merge 1 commit into from

Conversation

axitkhurana
Copy link

Summary: We lost SYMBOLICATE_MOBILE_DEBUG_HANDLE flag in some buck file refactoring, bringing it back to fetch module level information in profiling

Test Plan: Profiling output has module level information

Reviewed By: kimishpatel

Differential Revision: D37970958

@facebook-github-bot
[PTE] Fix module level information in profiling
98ba1d7 
Summary: We lost SYMBOLICATE_MOBILE_DEBUG_HANDLE flag in some buck file refactoring, bringing it back to fetch module level information in profiling

Test Plan: Profiling output has module level information

Reviewed By: kimishpatel

Differential Revision: D37970958

fbshipit-source-id: 6721b92e2ee07bb5ade68ded255264e02f10753a
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 19, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 98ba1d7 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37970958

@axitkhurana
Copy link
Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @axitkhurana.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 20, 2022
@facebook-github-bot
[PTE] Fix module level information in profiling (#81727) (#81727)
19a1163 
Summary:
We lost SYMBOLICATE_MOBILE_DEBUG_HANDLE flag in some buck file refactoring, bringing it back to fetch module level information in profiling

Pull Request resolved: #81727
Approved by: https://github.com/linbinyu

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/99cb5fde12c892d02ce4f4ad3ae1d1928e410ff5

Test plan from GitHub:
Profiling output has module level information

Reviewed By: kimishpatel, jeanschmidt

Differential Revision: D37970958

Pulled By: axitkhurana

fbshipit-source-id: bb8810e76c54a5048838551926d58bb6e7954ded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linbinyu linbinyu linbinyu approved these changes

@kimishpatel kimishpatel Awaiting requested review from kimishpatel

Assignees

No one assigned

Labels

cla signed fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@axitkhurana @facebook-github-bot @pytorchmergebot @linbinyu